Remove cudarc - #143
Merged
Merged
Remove cudarc#143
Conversation
Cargo will detect dependencies within workspace itself.
```
--> Cargo.toml:14:1
|
14 | trtexec-rs = { path = "trtx" }
| ^^^^^^^^^^
|
= note: `cargo::unused_workspace_dependencies` is set to `warn` by default
help: consider removing the workspace dependency `trtexec-rs`
warning: unused workspace dependency `trtx-sys`
--> Cargo.toml:13:1
|
13 | trtx-sys = { path = "trtx-sys" }
| ^^^^^^^^
|
help: consider removing the workspace dependency `trtx-sys`
warning: workspace (manifest) generated 2 warnings
```
theHamsta
commented
Sep 23, 2026
| trtx-sys = { version = "0.8.1", path = "../trtx-sys", default-features = false } | ||
| thiserror = "2.0" | ||
| cxx = "1.0" | ||
| libc = "0.2" |
Contributor
Author
There was a problem hiding this comment.
never used. cargo warns about it
theHamsta
force-pushed
the
remove-cudarc
branch
3 times, most recently
from
September 23, 2026 15:28
78c6c57 to
18f7439
Compare
With rustnn/rustnn#185 most important consumer has vanished. People can now use the CUDA crate of their choice to interact with trtx. We won't have an extra version of cudarc.
theHamsta
force-pushed
the
remove-cudarc
branch
from
September 23, 2026 15:30
18f7439 to
957c054
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs follow-up in RustNN