Skip to content

add texture-render-health internal option key - #582

Merged
rustdesk merged 1 commit into
mainfrom
fix-texture-lifetime
Aug 13, 2026
Merged

add texture-render-health internal option key#582
rustdesk merged 1 commit into
mainfrom
fix-texture-lifetime

Conversation

@rustdesk

@rustdesk rustdesk commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Written by the texture-render watchdog / startup probe in the main repo; a failed record forces texture rendering off until it is cleared (probe pass or an explicit toggle of use-texture-render).

Summary by CodeRabbit

  • New Features
    • Added a public configuration option for monitoring texture-rendering health.

Written by the texture-render watchdog / startup probe in the main repo;
a failed record forces texture rendering off until it is cleared (probe
pass or an explicit toggle of use-texture-render).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 13, 2026 01:56
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b34b9d4f-095c-4c7d-ac5e-b3f44ea3befd

📥 Commits

Reviewing files that changed from the base of the PR and between f124c0a and d19ce39.

📒 Files selected for processing (1)
  • src/config.rs

📝 Walkthrough

Walkthrough

Adds the public OPTION_TEXTURE_RENDER_HEALTH configuration key with the value texture-render-health. The declaration documents that failed health states can change texture rendering to opt-in behavior.

Changes

Texture render health

Layer / File(s) Summary
Add texture render health key
src/config.rs
Defines OPTION_TEXTURE_RENDER_HEALTH and documents its texture-rendering behavior.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: 21pages, fufesou

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-texture-lifetime

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rustdesk
rustdesk merged commit 3ed9385 into main Aug 13, 2026
1 of 2 checks passed
@rustdesk
rustdesk deleted the fix-texture-lifetime branch August 13, 2026 01:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new configuration option key used to persist a texture-render “health” state, intended for internal use by a watchdog/startup probe so the application can disable texture rendering after a detected failure until cleared.

Changes:

  • Introduces a new keys::OPTION_TEXTURE_RENDER_HEALTH config key ("texture-render-health").
  • Documents (via inline comments) the intended semantics for “failed-*” values affecting the texture-render default.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants