feat(rendezvous): add UDP punch negotiation fields - #581
Open
Bia503 wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe rendezvous protobuf definitions add UDP punch token fields, NAT test nonces, and a registration capability flag. ChangesRendezvous protocol
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
FYI, I’m holding the follow-up client/hbbs PRs for now, since they depend on this protocol change and won’t pass CI against the current hbb_common. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds wire-compatible rendezvous protocol fields required for authenticated UDP hole-punch negotiation:
TestNatRequest.nonceTestNatResponse.noncePunchHole.udp_punch_tokenPunchHoleSent.udp_punch_tokenRegisterPk.udp_punch_token_supportedMotivation
The existing UDP candidate path does not have a server-verified completion signal.
These fields allow a rendezvous server to:
All fields are additive protobuf fields. Older clients and servers ignore them and
continue using the existing TCP/relay flow.
Follow-up
Client and hbbs support will be submitted separately after this protocol change.
Summary by CodeRabbit