x11: fix crash when XInput 2 is unavailable - #4660
Open
mTvare6 wants to merge 1 commit into
Open
Conversation
EventLoop::new() currently panics while handling the XIQueryVersion reply on servers that only support XI1, such as x2goagent. Propagate XInput initialization failures through the existing error path and return NotSupported when the server does not support XI2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventLoop::new()panics while handling theXIQueryVersionreply on X servers that only support XI1, such asx2goagent.This propagates XInput initialization failures through the existing error path and returns
NotSupportedwhen XI2 is unavailable. It does not add an XI1 fallback.Tested with:
x2goagent, XI 1.3: returnsErrwithout panickingXephyr, XI 2.4: event loop initializes successfully
Xorg, XI 2.3: event loop initializes successfully
Tested on all platforms changed
Added an entry to the
changelogmodule if knowledge of this change could be valuable to usersUpdated documentation to reflect any user-facing changes, including notes of platform-specific behavior — not applicable; no API change
Created or updated an example program if it would help users understand this functionality — not applicable