macOS: implement set_blur with NSVisualEffectView. kept private-apple-apis for the radius. - #4632
macOS: implement set_blur with NSVisualEffectView. kept private-apple-apis for the radius.#4632pszsh wants to merge 1 commit into
Conversation
3ac18e6 to
18d2a46
Compare
Yeah, I mean I could make a choice here, but I don't know if I'd make the one you would. It's really up to y'all. Please let me know if I'm just being a nuisance, I'm just trying to help but if the way I'm going about things is just wrong or fundamentally missing some larger point that I am not seeing for whatever reason, and I might as well not bother... I'd like to know that so that I can stop wasting everyone's time. I value your time, I am only trying to save you some. One way or another I would appreciate any feedback, to know if It's worth it to keep trying to make this pull request. Thanks, Jess |
61398cf to
78d2b13
Compare
|
Cool beans. Hope this is what you were looking for, if not, let me know and I'll try again. |
78d2b13 to
cb38b2a
Compare
da132af to
83baa7d
Compare
Fills in the TODO left when `CGSSetWindowBackgroundBlurRadius` moved behind `private-apple-apis`, so blur works again by default. The window's `contentView` is now a plain container `NSView` holding `WinitView`, and the effect view is installed as a sibling ordered below it, so the view returned by `raw-window-handle` is never unlinked from the window. With `private-apple-apis` enabled, the private API is used exactly as before. The material is tinted and follows the window's appearance, so the fixed radius of 80 is not reproduced; that stays available through the feature.
83baa7d to
19b8b7a
Compare
|
I'll just keep rebasing this until someone tells me otherwise. I figure when the time comes, if it's already passed the tests and up to date with the master, that will make your job easier. So, I'll keep bumping it. I hope I'm not bugging you whenever I do, that's not my intention. I appreciate y'all's work, thanks for doing this. Maintainers are my heros! |
2 participants
This is #4541 with the TODO filled in -
NSVisualEffectViewas the public default, your feature left alone for the radius.I tried to keep it simple, and answer @kchibisov's point about subviews, and follow the conventions I could see. The rest is in the changelog.
Let me know if you'd rather have it a different way. As before, happy to make changes.