Skip to content

Allow configuring whether to care about the CTS line #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meithecatte wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

Allow configuring whether to care about the CTS line #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ pub struct Config {
pub extra_stop_bits: bool,
/// Whether parity bits should be used.
pub parity: Parity,
/// Whether to wait for CTS before sending.
pub observe_cts: bool,
}

impl Config {
Expand All @@ -176,6 +178,7 @@ impl Config {
data_bits: WordLength::EightBits,
extra_stop_bits: false,
parity: Parity::Disabled,
observe_cts: false,
};
}

Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ impl<B: Backend> Uart16550<B> {

// Software flow control. TODO, what to do with hardware flow control?
// Is this something we can and should support?
if !mcr.contains(MCR::LOOP_BACK) && !msr.contains(MSR::CTS) {
if self.config.observe_cts && !mcr.contains(MCR::LOOP_BACK) && !msr.contains(MSR::CTS) {
return Err(ByteSendError::RemoteNotClearToSend);
}

Expand Down