Implement libs team refactor (RFC 3984)

[clarfonthey]

Note: blocked on RFC 3984 merging, still has a few unanswered questions like renaming Zulip streams. Tried to split into a few commits to make reviewing easier.

Resolved items:

• I'm not sure what the policy is for archived teams, especially when it comes to merging them into existing teams. I figured that since we have an explicit policy in the RFC for allowing alumni to be re-nominated, it would make sense to merge all the alumni here as well, but would also like some guidance on that. (this is fine)
• I also am not sure whether we truly need to keep the library contributors team archived at all since it functionally has no difference from the new libs team. The libs-API team specifically feels like it's worth tracking, though. (this is also fine)

Remaining items:

• Amanieu recommended just archiving t-libs/private; this would be something we want to do before merging this, since we don't want to add new libs members to it just to archive it.
• With that archived, it makes sense to rename t-libs/reviewers to t-libs/private also before merging.

[github-actions]

Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github
[INFO  rust_team::sync] 💻 Team Diffs:
    📝 Editing team 'rust-lang/libs':
      Adding member 'BurntSushi' with member role
      Adding member 'ChrisDenton' with member role
      Adding member 'Darksonn' with member role
      Adding member 'JohnTitor' with member role
      Adding member 'KodrAus' with member role
      Adding member 'LawnGnome' with member role
      Adding member 'Mark-Simulacrum' with maintainer role
      Adding member 'Noratrieb' with member role
      Adding member 'SimonSapin' with member role
      Adding member 'aapoalas' with member role
      Adding member 'adamgemmell' with member role
      Adding member 'calebzulawski' with member role
      Adding member 'clarfonthey' with member role
      Adding member 'cramertj' with member role
      Adding member 'davidtwco' with member role
      Adding member 'dtolnay' with member role
      Adding member 'folkertdev' with member role
      Adding member 'hanna-kruppe' with member role
      Adding member 'ibraheemdev' with member role
      Adding member 'jhpratt' with member role
      Adding member 'joboet' with member role
      Adding member 'kennytm' with member role
      Adding member 'm-ou-se' with member role
      Adding member 'nia-e' with member role
      Adding member 'programmerjake' with member role
      Adding member 'sayantn' with member role
      Adding member 'sunfishcode' with member role
      Adding member 'tgross35' with member role
      Adding member 'workingjubilee' with member role
      Adding member 'yaahc' with member role
    📝 Editing team 'rust-lang-nursery/libs':
      Adding member 'BurntSushi' with member role
      Adding member 'ChrisDenton' with member role
      Adding member 'Darksonn' with member role
      Adding member 'JohnTitor' with member role
      Adding member 'KodrAus' with maintainer role
      Adding member 'LawnGnome' with member role
      Adding member 'Mark-Simulacrum' with maintainer role
      Adding member 'Noratrieb' with member role
      Adding member 'SimonSapin' with member role
      Adding member 'aapoalas' with member role
      Adding member 'adamgemmell' with member role
      Adding member 'calebzulawski' with member role
      Adding member 'clarfonthey' with member role
      Adding member 'cramertj' with member role
      Adding member 'davidtwco' with member role
      Adding member 'dtolnay' with maintainer role
      Adding member 'folkertdev' with member role
      Adding member 'hanna-kruppe' with member role
      Adding member 'ibraheemdev' with member role
      Adding member 'jhpratt' with member role
      Adding member 'joboet' with member role
      Adding member 'kennytm' with maintainer role
      Adding member 'm-ou-se' with member role
      Adding member 'nia-e' with member role
      Adding member 'programmerjake' with member role
      Adding member 'sayantn' with member role
      Adding member 'sunfishcode' with member role
      Adding member 'tgross35' with member role
      Adding member 'workingjubilee' with member role
      Adding member 'yaahc' with member role
    ❌ Deleting team 'rust-lang/libs-api'
    ❌ Deleting team 'rust-lang/libs-contributors'
    ❌ Deleting team 'rust-lang-nursery/libs-api'
    ❌ Deleting team 'rust-lang-nursery/libs-contributors'
    💻 Repo Diffs:
    📝 Editing repo 'rust-lang/api-guidelines':
      Permission Changes:
        Removing team 'libs-api''s write permission 
    📝 Editing repo 'rust-lang/enzyme':
      Permission Changes:
        Removing team 'libs-api''s maintain permission 
    📝 Editing repo 'rust-lang/goals':
      Permission Changes:
        Removing team 'libs-api''s maintain permission 
    📝 Editing repo 'rust-lang/hashbrown':
      Permission Changes:
        Removing team 'libs-contributors''s write permission 
    📝 Editing repo 'rust-lang/libs-team':
      Permission Changes:
        Removing team 'libs-contributors''s maintain permission 
        Removing team 'libs-api''s maintain permission 
    📝 Editing repo 'rust-lang/packed_simd':
      Permission Changes:
        Removing team 'libs-api''s write permission 
        Removing team 'libs-contributors''s write permission 
    📝 Editing repo 'rust-lang/rust':
      Permission Changes:
        Removing team 'libs-api''s write permission 
        Removing team 'libs-contributors''s write permission 
    📝 Editing repo 'rust-lang/rust-forge':
      Permission Changes:
        Removing team 'libs-api''s maintain permission 
    📝 Editing repo 'rust-lang/rustc-dev-guide':
      Permission Changes:
        Removing team 'libs-contributors''s write permission 
        Removing team 'libs-api''s write permission 
    📝 Editing repo 'rust-lang/std-dev-guide':
      Permission Changes:
        Removing team 'libs-contributors''s write permission 
        Removing team 'libs-api''s write permission 
    📝 Editing repo 'rust-lang/stdarch':
      Permission Changes:
        Removing team 'libs-api''s write permission 
        Removing team 'libs-contributors''s write permission 
    📝 Editing repo 'rust-lang/wg-allocators':
      Permission Changes:
        Removing team 'libs-contributors''s write permission 
        Removing team 'libs-api''s write permission 

[nia-e]

I think the Zulip stream setup proposed here makes sense, and I wouldn't change it. Same with merging the alumni, it checks out. The only bit I'm not 100% sure on archiving vs deleting libs-contributors & libs-api since functionally they're all just being merged, but I think this is the right call for historical preservation reasons.

lgtm, and I'm happy to merge this as-is as soon as the refactor FCP is done

[clarfonthey]

Probably still gonna need a sign off from @Amanieu too as a team lead but otherwise, yeah, I figure Zulip rearranging can happen after the fact.

[Amanieu]

We should just drop the private channel. It's basically dead and all the internal discussions are happening on the t-libs/reviewers channel. I see no need to keep a separate channel for libs-fcp.

[clarfonthey]

I'm fine with that, although my inclination is to assign libs-fcp to it first so it doesn't dump the new libs team in there immediately, then delete it in a future PR. Not that it matters, since it's not going to reveal old messages or anything, but to avoid confusion.

Since I believe deleting it from this PR will just cause its permissions to remain the same, which would dump all of the new libs into it.

[nia-e]

i believe perms are per-user, not per-group. either way this is smth infra can clarify, it seems we agree on the intent being to archive that channel without adding anyone new

[clarfonthey]

AFAIK the Zulip channel has group permissions, so the users would be added because their group changed, not because the channel changed. But either way, yeah, I'm happy to remove the channel from the PR if infra is fine coordinating that.

We would also want to name the reviewers channel to t-libs/private too, presumably.

[jieyouxu]

Permissions are tied to per-user at least from I can tell.

[jieyouxu]

team-repo-admin approval given, this needs an infra-admin review as well since this modifies rust-lang/rust permissions.

[jieyouxu]

NB: this touches rust-lang/rust

[jieyouxu]

NB: I'm not sure if this is still accurate for what libs want to describe the FCP subteam as, but also this is easy to change so yeah.

[jieyouxu]

Permissions are tied to per-user at least from I can tell.