Update slug style to use _ instead of - - #1426
Merged
Merged
Conversation
Member
Author
|
cc @davidtwco |
davidtwco
reviewed
Aug 12, 2022
davidtwco
left a comment
davidtwco
left a comment
Member
There was a problem hiding this comment.
LGTM, a couple of fixes, almost all correcting my previous mistakes.
est31
force-pushed
the
fluent_underscore
branch
2 times, most recently
from
August 12, 2022 10:27
e6ed8a9 to
4165dfb
Compare
JohnTitor
added
the
S-waiting-on-review
davidtwco
reviewed
Aug 15, 2022
est31
force-pushed
the
fluent_underscore
branch
from
August 16, 2022 06:04
4165dfb to
6e0663e
Compare
Member
|
rust-lang/rust#100377 has landed now |
Member
|
@davidtwco you should be able to merge this if you are happy |
Member
I'm still waiting on a comment to be resolved. |
est31
force-pushed
the
fluent_underscore
branch
from
August 16, 2022 18:35
6e0663e to
cc5bac8
Compare
davidtwco
requested changes
Aug 17, 2022
davidtwco
left a comment
davidtwco
left a comment
Member
There was a problem hiding this comment.
Thanks for sticking with this, there's a few more pre-existing out-of-date parts that I'd appreciate if you updated, then we can merge this :)
| diag.span_label( | ||
| self.span, | ||
| rustc_errors::DiagnosticMessage::fluent_attr("typeck-field-already-declared", "label") | ||
| rustc_errors::DiagnosticMessage::FluentAttr( |
Member
There was a problem hiding this comment.
We use the typed identifiers here too...
| diag.span_label( | ||
| self.prev_span, | ||
| rustc_errors::DiagnosticMessage::fluent_attr("typeck-field-already-declared", "previous-decl-label") | ||
| rustc_errors::DiagnosticMessage::FluentAttr( |
| match self { | ||
| ExpectedReturnTypeLabel::Unit { span } => { | ||
| diag.span_label(span, DiagnosticMessage::fluent("typeck-expected-default-return-type")) | ||
| diag.span_label(span, DiagnosticMessage::fluent("typeck_expected_default_return_type")) |
| ExpectedReturnTypeLabel::Other { span, expected } => { | ||
| diag.set_arg("expected", expected); | ||
| diag.span_label(span, DiagnosticMessage::fluent("typeck-expected-return-type")) | ||
| diag.span_label(span, DiagnosticMessage::fluent("typeck_expected_return_type")) |
JohnTitor
added
S-waiting-on-author
Due to changes by rust-lang/rust#100377
est31
force-pushed
the
fluent_underscore
branch
from
August 17, 2022 18:11
cc5bac8 to
f6c3767
Compare
davidtwco
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to changes by rust-lang/rust#100377