Fix path_trailing_sep methods for Windows verbatim paths - #162643
Open
ChrisDenton wants to merge 1 commit into
Open
Fix path_trailing_sep methods for Windows verbatim paths#162643ChrisDenton wants to merge 1 commit into
path_trailing_sep methods for Windows verbatim paths#162643ChrisDenton wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-libs
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally on Windows the path separator is either
\or/but for verbatim paths it is only\. Currently the unstablepath_trailing_sepmethods (#142503) do not take that into account and just use the generalis_sep_bytemethod.This PR changes it to use the internal
Components::is_sep(self, b)method that takes into account verbatim paths.