Rollup of 5 pull requests - #162617
Closed
jhpratt wants to merge 23 commits into
Closed
Conversation
Explain the byte alphabet, padding, definition markers, and empty layouts. Cover surviving and fully pruned alternatives, including nested sequences, and replace obsolete visibility terminology. Validation: ./x test compiler/rustc_transmute Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
Describe the query stages and deferred obligations, correct stale comments, and exercise both validity settings in the powerset test. Add direct checks for condition grouping, error selection, and quantifier short-circuiting. Document the existing conditional behavior of Answer::or without changing it. Validation: ./x test compiler/rustc_transmute Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
Specify interval-union inputs and output partitions and test overlaps, boundaries, and coalescing. Mark DOT entry and accepting states distinctly, log full graphs once per query, and omit the memoization cache from spans. Validation: ./x test compiler/rustc_transmute A manual bool identity query with RUSTC_LOG=rustc_transmute=debug confirmed one source graph, one destination graph, and no cache dumps. Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
Use each YawningVoid type as a destination in its UI test instead of repeating the zero-sized Void case. Equal-sized u128 sources prevent a size mismatch from masking a failure to reject an uninhabited destination. Update the copied explanations and regenerate the diagnostic snapshot. Validation: ./x test tests/ui/transmutability Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
…quiered for clippy analysis)
These are dead since the old emitter was removed in Jan 2026 (3ccabc6). Also removed: `BRIGHT_BLUE`, `Level::color`, and a couple of `level` fn parameters.
It has a single use, where it is passed in to `format_diag_messages` which then discards it. So that use can be replaced with `Style::NoStyle`.
`format_diag_messages` always constructs a `String`, so it can just return that. This simplifies various call sites.
When there's a single message, `format_diag_message` suffices.
Use the `FatalError` re-export from `rustc_errors` instead of `rustc_span`, because that's what's normally done.
Currently `Level` is used for both diagnostics and subdiagnostics. But both diagnostics and subdiagnostics only use some of the levels. This commit introduces `Sublevel` to tighten up the representation and prevent impossible combinations.
Mingw used to have an incorrect import library for the synchronization functions `WaitOnAddress`, `WakeByAddressSingle` and `WakeByAddressAll`. This was fixed a long time ago and our windows-gnu targets require a much newer mingw in any case.
item_name fix Co-authored-by: Bruno Kolenbrander <59372212+mejrs@users.noreply.github.com>
Update `windows-bindgen` to 0.100.0 This release represents a major change in the way bindings are generated. See microsoft/windows-rs#4867 for details. In short, it now more directly follows the C headers. For the standard library's purposes this is mostly reflected in relatively minor type changes or with some `const` pointers becoming `mut`. There is however one big change that affects a lot of types. In the headers there are a lot of `#define`s like this: ```c #define GENERIC_READ (0x80000000L) #define GENERIC_WRITE (0x40000000L) ``` These are constants for the access mode. In this case they're explicitly declared as `L` (aka signed long) integer types (in other cases there's no type at all). However, this conflicts with how access mode constants are actually used. E.g., see `CreateFileW`: ```c WINBASEAPI HANDLE WINAPI CreateFileW( _In_ LPCWSTR lpFileName, _In_ DWORD dwDesiredAccess, _In_ DWORD dwShareMode, _In_opt_ LPSECURITY_ATTRIBUTES lpSecurityAttributes, _In_ DWORD dwCreationDisposition, _In_ DWORD dwFlagsAndAttributes, _In_opt_ HANDLE hTemplateFile ); ``` Here `dwDesiredAccess` is a `DWORD`, which in rust equates to `u32`. The constant being signed but the usage being unsigned is not a problem for C/C++. They will happily convert between types at the drop of a hat. Rust however is stricter, as you know. The old metadata used by `windows-bindgen` tried to try to fixup this mismatch but the new one goes strictly by what can be inferred from the headers. The hope in the future is that the headers themselves will be updated so better bindings can be directly derived from them.
Revert "Rollup merge of rust-lang#157518 - CAD97:xdg_basedir, r=aapoalas" This reverts commit ac80064, reversing changes made to 8d6b380. <!-- homu-ignore:start --> - rust-lang#157515 is superseded - This includes just the revert that's the first commit in rust-lang#158936
Basic cleanup in `rustc_transmute` The content of this PR was authored by an LLM. r? @jswrenn
…r=oli-obk Simplify diagnostic levels This PR separates diagnostic levels from subdiagnostic levels and does a few preliminary cleanups. Details in individual commits. r? @oli-obk
…tems, r=mejrs iter::repeat_with, iter::successors, iter::from_fn added as diagnostic items added iter::repeat_with, iter::successors, iter::from_fn as diagnostic items, in order for clippy to be able to register them and work with them. Link to clippy issue: rust-lang/rust-clippy#17719
rustbot
added
A-translation
Member
Author
|
@bors r+ p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 02daa64 with merge 840b8fa... Workflow: https://github.com/rust-lang/rust/actions/runs/34546279579 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
Rollup of 5 pull requests Successful merges: - #162270 (Update `windows-bindgen` to 0.100.0) - #162492 (Revert "Rollup merge of #157518 - CAD97:xdg_basedir, r=aapoalas") - #162607 (Basic cleanup in `rustc_transmute`) - #162514 (Simplify diagnostic levels) - #162613 (iter::repeat_with, iter::successors, iter::from_fn added as diagnostic items)
Member
Author
|
seemingly stalled |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. Auto build was cancelled due to the PR being closed. Cancelled workflows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
windows-bindgento 0.100.0 #162270 (Updatewindows-bindgento 0.100.0)rustc_transmute#162607 (Basic cleanup inrustc_transmute)r? @ghost
Create a similar rollup