Skip to content

Make VaArgSafe dyn-incompatible #162374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 2 commits into from
Sep 7, 2026
+2 −1
Merged

Make VaArgSafe dyn-incompatible #162374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16529d7
Make `VaArgSafe` dyn-incompatible
theemathas Sep 6, 2026
246105d
Acknowledge "breaking" change
theemathas Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions library/core/src/ffi/va_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ const impl<'f> Drop for VaList<'f> {
// meantime.
#[lang = "va_arg_safe"]
#[stable(feature = "c_variadic", since = "1.99.0")]
#[rustc_dyn_incompatible_trait]
pub impl(self) unsafe trait VaArgSafe {}

crate::cfg_select! {
Expand Down
2 changes: 1 addition & 1 deletion src/bootstrap/stdlib-semver-check-stamp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ Change this file to explicitly acknowledge making a breaking change to the Rust
If this file is modified in the same PR as the breaking change, then CI will not fail due to the
breaking change being detected by cargo-semver-checks.

Last change is for: https://github.com/rust-lang/rust/pull/155499
Last change is for: https://github.com/rust-lang/rust/pull/162374
Loading