Clean up some small things related to lint ambiguous_glob_imported_traits - #162176
Merged
rust-bors[bot] merged 2 commits intoSep 11, 2026
Merged
Conversation
fmease
added
the
C-cleanup
rustbot
added
S-waiting-on-review
Collaborator
|
r? @adwinwhite rustbot has assigned @adwinwhite. Use Why was this reviewer chosen?The reviewer was selected based on:
|
fmease
changed the title
ambiguous_glob_imported_traits
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
clean-up-ambig-glob-imp-traits
branch
2 times, most recently
from
September 2, 2026 09:58
a65b61a to
6c0654e
Compare
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
clean-up-ambig-glob-imp-traits
branch
from
September 8, 2026 20:59
6c0654e to
77c83e4
Compare
…tylistic conventions Namely: > Error, Warning, Note, and Help messages start with a lowercase letter and do not end with punctuation. From: <https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-output-style-guide>
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
Rollup merge of #162176 - fmease:clean-up-ambig-glob-imp-traits, r=adwinwhite Clean up some small things related to lint `ambiguous_glob_imported_traits` Cleaning up things I noticed in the vicinity while reviewing PR #157968 (which concerns lint `ambiguous_glob_imported_traits` and feature `supertrait_item_shadowing`). Namely, 1. turning two tuple struct variants into named ones to avoid "anonymous `bool`s" 2. fixing an inaccurate `supertrait_item_shadowing`-specific doc comment 3. applying the rules listed in our [Diagnostic output style guide](https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-output-style-guide) to the diagnostic of lint `ambiguous_glob_imported_traits` <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up things I noticed in the vicinity while reviewing PR #157968 (which concerns lint
ambiguous_glob_imported_traitsand featuresupertrait_item_shadowing).Namely,
bools"supertrait_item_shadowing-specific doc commentambiguous_glob_imported_traits(No LLM was or will be used by me during the entire creation process of this PR)