Some cleanups around fatal errors and delayed bugs

[bjorn3]

With the aim of making it easier to move some compiler passes to different locations. And in particular to allow moving them across has_errors_or_delayed_bugs calls. This is a prerequisite for a local change that improves the effectiveness of cargo build pipelining.

Fixes #152204

[rustbot]

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

[rustbot]

r? @mu001999

rustbot has assigned @mu001999.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 75 candidates
• Random selection from 18 candidates

[mejrs]

Only one of these errors has the E0080 code attached to it, can you make it consistent?

View changes since the review

[bjorn3]

E0080 indicates that a const failed to evaluate: https://doc.rust-lang.org/error_codes/E0080.html

A constant value failed to get evaluated.

Erroneous code example:

enum Enum {
    X = (1 << 500),
    Y = (1 / 0),
}

This error indicates that the compiler was unable to sensibly evaluate a constant expression that had to be evaluated. Attempting to divide by 0 or causing an integer overflow are two ways to induce this error.

Ensure that the expressions given can be evaluated as the desired integer type.

See the Discriminants section of the Reference for more information about setting custom integer types on enums using the repr attribute.

The first error however doesn't happen during const eval at all. It happens when determining the function ABI.

[mejrs]

Is removing this unwrap sound? ( alternatively, one could delay a bug in the err case)

View changes since the review

[bjorn3]

eval_static_initializer returns Result<_, ErrorGuranteed>.

[mejrs]

It returns Result<_, ErrorHandled> and ErrorHandled has a variant without an ErrorGuaranteed. I don't know whether that could happen here.

[bjorn3]

Right, ErrorHandled::TooGeneric can't happen here as statics are never generic. But will change it to a delayed bug anyway just in case.

[mejrs]

Thanks! I do occasionally see proposals for generic statics... so this delayed bug would be nice to have.

[mu001999]

r? mejrs

[mejrs]

r=me with delayed bug added and ci green

View changes since this review

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rustbot]

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

[bjorn3]

Since the review I added the delayed bug as requested and changed an ICE crash test to a build-fail test as the third commit fixes it.

@rustbot ready

[rust-log-analyzer]

The job test-x86_64-gnu-llvm-21 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests/ui/limits/issue-17913.rs stdout ----
Saved the actual 32bit.stderr to `/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/limits/issue-17913/issue-17913.32bit.stderr`
diff of 32bit.stderr:

+ error: values of the type `[&usize; usize::MAX]` are too big for the target architecture
+   --> $SRC_DIR/alloc/src/boxed.rs:LL:COL
+ 
1 error[E0080]: values of the type `[&usize; usize::MAX]` are too big for the target architecture
2   --> $SRC_DIR/core/src/mem/mod.rs:LL:COL
3    |

9 LL |     let a: Box<_> = Box::new([&n; SIZE]);
10    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
11 
- error: aborting due to 1 previous error
+ error: aborting due to 2 previous errors
13 
14 For more information about this error, try `rustc --explain E0080`.
15 

Note: some mismatched output was normalized before being compared
-   --> /rustc/FAKE_PREFIX/library/alloc/src/boxed.rs:290:4
+ error: values of the type `[&usize; usize::MAX]` are too big for the target architecture
+   --> $SRC_DIR/alloc/src/boxed.rs:LL:COL
+ 
+ error: aborting due to 2 previous errors


The actual 32bit.stderr differed from the expected 32bit.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args limits/issue-17913.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/limits/issue-17913.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=i686-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/limits/issue-17913" "-Znext-solver=coherence" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=x86_64-linux-gnu-gcc"
stdout: none
--- stderr -------------------------------
error: values of the type `[&usize; usize::MAX]` are too big for the target architecture
##[error]  --> /rustc/FAKE_PREFIX/library/alloc/src/boxed.rs:290:4

error[E0080]: values of the type `[&usize; usize::MAX]` are too big for the target architecture
##[error]  --> /rustc/FAKE_PREFIX/library/core/src/mem/mod.rs:1463:24
   |
   = note: evaluation of `<[&usize; usize::MAX] as std::mem::SizedTypeProperties>::SIZE` failed here

note: the above error was encountered while instantiating `fn Box::<[&usize; usize::MAX]>::new`
  --> /checkout/tests/ui/limits/issue-17913.rs:16:21
   |
LL |     let a: Box<_> = Box::new([&n; 0xFFFFFFFF_usize]);
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0080`.