Skip to content

Add rust_analyzer to check-cfg names - #160878

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
dronavallipranav:add-rust-analyzer-cfg
Aug 12, 2026
Merged

Add rust_analyzer to check-cfg names#160878
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
dronavallipranav:add-rust-analyzer-cfg

Conversation

@dronavallipranav

@dronavallipranav dronavallipranav commented Aug 10, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Add rust_analyzer as a known cfg name, set to expect no values
Add test to verify name is recognized and warned on setting a value

Fixes #160736

r? @Urgau

@rustbot

rustbot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in cfg and check-cfg configuration

cc @Urgau

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 10, 2026
@rustbot

rustbot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @Urgau (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau

Urgau commented Aug 11, 2026

Copy link
Copy Markdown
Member

Thanks, could you also update the list on the documentation: https://github.com/rust-lang/rust/blob/main/src/doc/rustc/src/check-cfg.md#well-known-names-and-values

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026
@rustbot

rustbot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot

rustbot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/doc/rustc/src/check-cfg.md

cc @Urgau

@dronavallipranav

dronavallipranav commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Ahhh yea of course!

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2026
Urgau
Urgau approved these changes Aug 11, 2026
View reviewed changes

@Urgau Urgau left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

This follows #125241 where rust_analyzer was added as a predefined tool, which is available on stable.

View changes since this review

@Urgau

Urgau commented Aug 11, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 4789fa3 has been approved by Urgau

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#160878 - dronavallipranav:add-rust-analyzer…
ce0d50c 
…-cfg, r=Urgau

Add rust_analyzer to check-cfg names

Add rust_analyzer as a known cfg name, set to expect no values
Add test to verify name is recognized and warned on setting a value

Fixes rust-lang#160736

r? @Urgau
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 11, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Aug 11, 2026
@bors
Auto merge of #160929 - JonathanBrouwer:rollup-q762upg, r=JonathanBro…
8c19109 
…uwer

Rollup of 10 pull requests

Successful merges:

 - #160620 (Do not pass `-no-pie` on Windows)
 - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion)
 - #160760 (Miri: give the incremental session a chance to finish)
 - #160854 (Add -Zwasm-proc-macros flag)
 - #160868 (std: Adjust cfgs again for TLS on WASI)
 - #160894 (Allow running an arbitrary number of try jobs per PR)
 - #160790 (rustc-book: update sys-v abi link)
 - #160878 (Add rust_analyzer to check-cfg names)
 - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency)
 - #160920 (No longer mention the removed generic)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#160878 - dronavallipranav:add-rust-analyzer…
4802008 
…-cfg, r=Urgau

Add rust_analyzer to check-cfg names

Add rust_analyzer as a known cfg name, set to expect no values
Add test to verify name is recognized and warned on setting a value

Fixes rust-lang#160736

r? @Urgau
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 11, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#160878 - dronavallipranav:add-rust-analyzer…
7999121 
…-cfg, r=Urgau

Add rust_analyzer to check-cfg names

Add rust_analyzer as a known cfg name, set to expect no values
Add test to verify name is recognized and warned on setting a value

Fixes rust-lang#160736

r? @Urgau
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 11, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Aug 11, 2026
@bors
Auto merge of #160948 - JonathanBrouwer:rollup-fyMZkZ4, r=JonathanBro…
7b8bbff 
…uwer

Rollup of 14 pull requests

Successful merges:

 - #160620 (Do not pass `-no-pie` on Windows)
 - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion)
 - #160760 (Miri: give the incremental session a chance to finish)
 - #160854 (Add -Zwasm-proc-macros flag)
 - #160868 (std: Adjust cfgs again for TLS on WASI)
 - #160894 (Allow running an arbitrary number of try jobs per PR)
 - #160790 (rustc-book: update sys-v abi link)
 - #160878 (Add rust_analyzer to check-cfg names)
 - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency)
 - #160920 (No longer mention the removed generic)
 - #160921 (rustdoc: Fix invalid CSS classes generated for notable items)
 - #160924 (split up `rustc_session`)
 - #160934 (Ensure TLS accesses don't call the global allocator through panic)
 - #160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)
@jhpratt jhpratt mentioned this pull request Aug 12, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Aug 12, 2026
@bors
Auto merge of #160954 - jhpratt:rollup-Rlls6YC, r=jhpratt
793b589 
Rollup of 14 pull requests

Successful merges:

 - #160620 (Do not pass `-no-pie` on Windows)
 - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion)
 - #160854 (Add -Zwasm-proc-macros flag)
 - #160868 (std: Adjust cfgs again for TLS on WASI)
 - #160882 (Add basic `splat` support to `rustdoc`)
 - #160894 (Allow running an arbitrary number of try jobs per PR)
 - #160790 (rustc-book: update sys-v abi link)
 - #160878 (Add rust_analyzer to check-cfg names)
 - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency)
 - #160920 (No longer mention the removed generic)
 - #160921 (rustdoc: Fix invalid CSS classes generated for notable items)
 - #160924 (split up `rustc_session`)
 - #160934 (Ensure TLS accesses don't call the global allocator through panic)
 - #160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)
@rust-bors
rust-bors Bot merged commit e5ee77d into rust-lang:main Aug 12, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Aug 12, 2026
rust-timer added a commit that referenced this pull request Aug 12, 2026
@rust-timer
Unrolled build for #160878
19a4408 
Rollup merge of #160878 - dronavallipranav:add-rust-analyzer-cfg, r=Urgau

Add rust_analyzer to check-cfg names

Add rust_analyzer as a known cfg name, set to expect no values
Add test to verify name is recognized and warned on setting a value

Fixes #160736

r? @Urgau
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

rust_analyzer is an unexpected cfg condition

4 participants

@dronavallipranav @rustbot @rust-log-analyzer @Urgau