Rollup of 5 pull requests by jhpratt · Pull Request #160789 · rust-lang/rust

jhpratt · 2026-08-09T03:52:00Z

Successful merges:

Initial implementation of named Fn trait parameters #158517 (Initial implementation of named Fn trait parameters)
check if len of array const arg matches the expected len of the type when lowering to valtree #158587 (check if len of array const arg matches the expected len of the type when lowering to valtree)
Add regression test for cross-crate assoc const private field leak in rustdoc #160748 (Add regression test for cross-crate assoc const private field leak in rustdoc)
remove old update mechanism #160708 (remove old update mechanism)
Fix autodiff_illegal.rs test #160768 (Fix autodiff_illegal.rs test)

…ameters, r=JohnTitor Initial implementation of named `Fn` trait parameters This is an initial implementation of the feature `named_fn_trait_parameters`. This implementation is incomplete (and also marked as such) , and needs significant further changes to be implemented correctly. To keep the size of this PR managable, I propose we do this in follow-up PRs. I've added a test that shows the current behaviour, with `FIXME` comments where the test output is currently incorrect. Tracking issue: rust-lang#158499 Accepted RFC: rust-lang/rfcs#3955

check if len of array const arg matches the expected len of the type when lowering to valtree When creating valtrees for arrays passed as const args in `lower_const_arg_array`, we assume the array has the correct length without actually checking the length of the arg, leading to UB at runtime (rust-lang#155168) or an ICE during CTFE (rust-lang#151079). This PR adds a check comparing the expected length of the type with the actual number of elements, similar to `lower_const_arg_tup`. fixes rust-lang#155168

…eGomez Add regression test for cross-crate assoc const private field leak in rustdoc Closes rust-lang#99630 adds a rustdoc test, reexporting a type must not leak the private field

…ism, r=Mark-Simulacrum remove old update mechanism

@ZuseZ4

…=mejrs,ZuseZ4 Fix autodiff_illegal.rs test This fixes the current CI failure: rust-lang#160761 (comment) r? @ZuseZ4

jhpratt · 2026-08-09T03:52:11Z

@bors r+ p=5

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-,x86_64-mingw-1,i686-msvc-

rust-bors · 2026-08-09T03:52:14Z

📌 Commit f5c9a72 has been approved by jhpratt

It is now in the queue for this repository.

Rollup of 5 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-* try-job: x86_64-mingw-1 try-job: i686-msvc-*

rust-bors · 2026-08-09T06:58:57Z

☀️ Try build successful (CI)
Build commit: 5935028 (5935028fb25fa0deb7251544b7749991f78cd2f5)
Base parent: 4667d75 (4667d75565e47ba5df36c0df598c556b543e8624)

rust-bors · 2026-08-09T08:25:59Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 10m 32s
Pushing 153ecc4 to main...

rust-timer · 2026-08-09T08:27:30Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#158517	Initial implementation of named `Fn` trait parameters	`46acd848c6b4c8cce41d89a4da179a896261cca0` (link)
#158587	check if len of array const arg matches the expected len of…	`0fc1b525bd79609487d8a7e985e23f98a726781e` (link)
#160748	Add regression test for cross-crate assoc const private fie…	`c0bbab77d195e1fb7b06605a04fcd1d1e78d3007` (link)
#160708	remove old update mechanism	`4ee128bde3dcb1a049f9196306c891aea03be3c0` (link)
#160768	Fix autodiff_illegal.rs test	`b7148e02d3248369b6c4cbf4b7b13b02579baeb3` (link)

previous master: 4667d75565

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-08-09T08:29:15Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4667d75 (parent) -> 153ecc4 (this PR)

Test differences

Show 15 test diffs

Stage 1

[ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J1)
[ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J1)
[ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J1)
[ui (polonius)] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J3)
[ui (polonius)] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J3)
[ui (polonius)] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J3)
[crashes] tests/crashes/160553.rs: [missing] -> pass (J4)
[rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J4)

Stage 2

[rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J0)
[crashes] tests/crashes/160553.rs: [missing] -> pass (J2)
[ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J5)
[ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J5)
[ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J5)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 153ecc4f74035b709bb3e1eb9546f1d934865042 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-i686-msvc: 1h 13m -> 1h 57m (+59.0%)
dist-x86_64-msvc-alt: 1h 48m -> 2h 44m (+51.4%)
x86_64-gnu: 1h 41m -> 2h 23m (+42.1%)
i686-gnu-nopt-1: 1h 38m -> 2h 16m (+38.6%)
dist-riscv64-linux-musl: 1h 3m -> 1h 25m (+34.8%)
x86_64-gnu-llvm-21-3: 1h 17m -> 1h 40m (+29.8%)
dist-x86_64-freebsd: 1h 24m -> 1h (-28.0%)
dist-x86_64-musl: 1h 47m -> 2h 14m (+25.8%)
i686-gnu-nopt-2: 2h 19m -> 1h 44m (-25.6%)
x86_64-rust-for-linux: 51m 30s -> 38m 25s (-25.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-08-09T09:09:05Z

Finished benchmarking commit (153ecc4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.0%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	9.4%	[9.4%, 9.4%]	1
Regressions ❌ (secondary)	3.5%	[0.5%, 7.7%]	7
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-2.1%	[-4.3%, -0.5%]	5
All ❌✅ (primary)	4.0%	[-1.4%, 9.4%]	2

Cycles

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.1%	[0.4%, 4.9%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.2%	[-4.7%, -0.5%]	12
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 458.83s -> 458.036s (-0.17%)
Artifact size: 398.59 MiB -> 398.61 MiB (0.01%)

JonathanBrouwer and others added 13 commits July 31, 2026 13:27

Add named_fn_trait_parameters feature gate

0efc299

Implement named fn trait parameters

858e064

Add test for named fn trait parameters

e2a4a58

Mark named_fn_trait_parameters as incomplete

6c901ce

check if len of array const arg matches the expected len

d43f980

remove old update mechanism

fc6672e

Add regression test for cross-crate assoc const private field leak

1a04912

Add expected error messages to autodiff_illegal.rs

acd2f65

Rollup merge of rust-lang#160748 - zakrad:regr-test-99630, r=Guillaum…

1dc2a9e

…eGomez Add regression test for cross-crate assoc const private field leak in rustdoc Closes rust-lang#99630 adds a rustdoc test, reexporting a type must not leak the private field

Rollup merge of rust-lang#160708 - marcoieni:remove-old-update-mechan…

d023954

…ism, r=Mark-Simulacrum remove old update mechanism

Rollup merge of rust-lang#160768 - JonathanBrouwer:fix_autodiff_ci, r…

f5c9a72

…=mejrs,ZuseZ4 Fix autodiff_illegal.rs test This fixes the current CI failure: rust-lang#160761 (comment) r? @ZuseZ4

rust-bors Bot added the rollup A PR which is a rollup label Aug 9, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2026

rust-bors Bot merged commit 153ecc4 into rust-lang:main Aug 9, 2026
15 checks passed

rustbot added this to the 1.99.0 milestone Aug 9, 2026

Navigation Menu

Uh oh!

Uh oh!

Rollup of 5 pull requests - #160789

Rollup of 5 pull requests#160789
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02

jhpratt commented Aug 9, 2026

Uh oh!

jhpratt commented Aug 9, 2026

Uh oh!

rust-bors Bot commented Aug 9, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 9, 2026

Uh oh!

rust-bors Bot commented Aug 9, 2026

Uh oh!

Uh oh!

rust-timer commented Aug 9, 2026

Uh oh!

github-actions Bot commented Aug 9, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Aug 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

jhpratt commented Aug 9, 2026

Uh oh!

jhpratt commented Aug 9, 2026

Uh oh!

rust-bors Bot commented Aug 9, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 9, 2026

Uh oh!

rust-bors Bot commented Aug 9, 2026

Uh oh!

Uh oh!

rust-timer commented Aug 9, 2026

Uh oh!

github-actions Bot commented Aug 9, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Aug 9, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants