bootstrap: Enable rustdoc mergeable CCI for std docs - #160724
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Ideally we'd enable it for the compiler docs too, though that's blocked on fixing some hacks in bootstrap related to shared build directories.
04430f5 to
138beab
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
|
|
It would be good if we could do some kind of manual testing of the generated docs to make sure everything looks OK. Can that be done with artifacts from a try job? |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
I've found two problems,
|
|
I think we also have to wait for a cargo bootstrap bump so we get the fix for Rustdoc flags... sigh |
It doesn't do anything, and Cargo doesn't do its fingerprint metadata correctly in this mode. Fixes a bug we found while working on enabling this feature for the standard library: rust-lang/rust#160724 (comment) - [x] I did not use an LLM to create a change in this PR.
Ideally we'd enable it for the compiler docs too, though that's blocked on fixing some hacks in bootstrap related to shared build directories.