Skip to content

Revert "Single-pass ASCII lower/upper case conversion" for benchmark - #160703

Closed
JonathanBrouwer wants to merge 1 commit into
rust-lang:mainfrom
JonathanBrouwer:revert-ascii
Closed

Revert "Single-pass ASCII lower/upper case conversion" for benchmark#160703
JonathanBrouwer wants to merge 1 commit into
rust-lang:mainfrom
JonathanBrouwer:revert-ascii

Conversation

@JonathanBrouwer

@JonathanBrouwer JonathanBrouwer commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

PR exists only to do a perf run of #160480

  • I did not use an LLM to create a change in this PR.
  • I used an LLM to create a change in this PR, and I have explained below how it was used.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 7, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 7, 2026
Revert "Single-pass ASCII lower/upper case conversion" for benchmark
@rust-bors

rust-bors Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 792df37 (792df37c7166d19d203a052924afc5bcac1368db)
Base parent: 65bcac4 (65bcac45b3d8a8b2126e5cc844cf6fff5795d32a)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (792df37): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.8% [-1.6%, -0.3%] 7
Improvements ✅
(secondary)
-0.8% [-1.6%, -0.5%] 5
All ❌✅ (primary) -0.6% [-1.6%, 0.7%] 8

Max RSS (memory usage)

Results (primary -3.5%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.5% [0.4%, 0.8%] 4
Improvements ✅
(primary)
-3.5% [-3.5%, -3.5%] 1
Improvements ✅
(secondary)
-1.1% [-1.7%, -0.5%] 2
All ❌✅ (primary) -3.5% [-3.5%, -3.5%] 1

Cycles

Results (secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.1% [0.5%, 2.8%] 10
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.7% [-1.1%, -0.4%] 7
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.6%, secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.7% [-2.5%, -0.1%] 18
Improvements ✅
(secondary)
-1.9% [-1.9%, -1.9%] 1
All ❌✅ (primary) -0.6% [-2.5%, 0.6%] 19

Bootstrap: 458.664s -> 461.289s (0.57%)
Artifact size: 398.60 MiB -> 398.63 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 7, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants