enable next solver by default in orphanck - #160668
Conversation
|
This PR changes a file inside |
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
enable next solver by default in orphanck
This comment has been minimized.
This comment has been minimized.
|
any breakage caused by this would also be caught by #133502. So I don't think this needs a separate crater run actually |
|
@rfcbot fcp merge types |
|
@lcnr has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
Finished benchmarking commit (c029389): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -4.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 457.798s -> 459.043s (0.27%) |
Orphan checking was supposed to use next solver as well when
-Znext-solver=coherencegot stabilized, but it never actually did, so this PR fixes that as part of the effort here: #t-types/call-for-participation > rip out old solver coherence support @ 💬also fixes #149703, incidentally!
r? lcnr