introduce copy_drop_in_place lint to rustc_lint - #160225
Closed
EvoPot wants to merge 1 commit into
Closed
Conversation
This PR introduces the `copy_drop_in_place` lint that activates when `std::ptr::drop_in_place` is called with a pointer to a Copy type.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
Seems like we raced each other 😄 I just opened #160229 to fix it. Happy to drop my PR and help you. |
Contributor
Author
Is that really okay? Mine introduces a new lint and doesn't work on methods. I personally think yours should go through. |
Contributor
Author
|
Update : I closed it away to not confuse maintainers |
Member
I think so, lints are allowed to change, and in this case it merely extends the lint to do the same thing across an indirection; but I've nominated the lint for the language team to consider it (with the I-lang-nominated label). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
copy_drop_in_placelint that activates whenstd::ptr::drop_in_placeis called with a pointer to a Copy type.See issue #160127
r? rust-lang/diagnostics