Skip to content

Improve expect messages in fmt docs - #159972

Open
kunwarpadda wants to merge 1 commit into
rust-lang:mainfrom
kunwarpadda:issue-159751-fmt-expect-messages
Open

Improve expect messages in fmt docs#159972
kunwarpadda wants to merge 1 commit into
rust-lang:mainfrom
kunwarpadda:issue-159751-fmt-expect-messages

Conversation

@kunwarpadda

Copy link
Copy Markdown

Related issue: #159751

Updates the two user-facing expect messages in
library/core/src/fmt/mod.rs to follow the recommended message style.

Tests:

  • ./x test library/core --doc

Copilot AI review requested due to automatic review settings July 26, 2026 16:35
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 26, 2026
@rustbot

rustbot commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 6 candidates

This comment was marked as spam.

@Kivooeo

Kivooeo commented Jul 27, 2026

Copy link
Copy Markdown
Member

was LLM used for this and if so why?

@apiraino

Copy link
Copy Markdown
Contributor

@kunwarpadda please disable Copilot in your GitHub settings and don't trigger unprompted reviews from bots in our repository, thanks.

@kunwarpadda

Copy link
Copy Markdown
Author

was LLM used for this and if so why?

Yes, I used an LLM as a quick sanity check to ensure the wording followed the recommended expect message style.

@rust-bors

rust-bors Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #160627) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants