Make `char::is_default_ignorable` unstably public by Jules-Bertholet · Pull Request #157944 · rust-lang/rust

Jules-Bertholet · 2026-06-15T22:47:18Z

Similar to #154849; this function is used in the implementation of char::escape_debug(), and there's no reason to force crates to duplicate a data table that std has to ship anyway.

I'll add a tracking issue if this is approved.

(I'll do the other data tables from #155527 in separate PRs.)

@rustbot label A-Unicode T-libs-api

Tracking issue: #160583

r? @Mark-Simulacrum

Mark-Simulacrum · 2026-06-18T12:28:15Z

r=me here, I think this one is probably non-controversial so no need for an ACP. Worst case we move it back to private.

@rustbot

…ivate-use, r=Mark-Simulacrum Make `char::is_private_use` and `char::is_assigned` unstably public See also rust-lang#157944, rust-lang#154849. These functions are used in the implementation of `char::escape_debug()`, and there's no reason to force crates to duplicate data tables that std has to ship anyway. `is_assigned` is especially useful because crates relying on the stability guarantees of the other Unicode methods in `char` may wish to reject unassigned characters where those guarantees do not hold. I'll add a tracking issue if this is approved. The `is_assigned` vs `is_unassigned` bikeshed probably needs libs-API review before merging? @rustbot label A-Unicode T-libs-api r? @Mark-Simulacrum

@rustbot

…ivate-use, r=Mark-Simulacrum Make `char::is_private_use` and `char::is_assigned` unstably public See also rust-lang#157944, rust-lang#154849. These functions are used in the implementation of `char::escape_debug()`, and there's no reason to force crates to duplicate data tables that std has to ship anyway. `is_assigned` is especially useful because crates relying on the stability guarantees of the other Unicode methods in `char` may wish to reject unassigned characters where those guarantees do not hold. I'll add a tracking issue if this is approved. The `is_assigned` vs `is_unassigned` bikeshed probably needs libs-API review before merging? @rustbot label A-Unicode T-libs-api r? @Mark-Simulacrum

@rustbot

…ivate-use, r=Mark-Simulacrum Make `char::is_private_use` and `char::is_assigned` unstably public See also rust-lang#157944, rust-lang#154849. These functions are used in the implementation of `char::escape_debug()`, and there's no reason to force crates to duplicate data tables that std has to ship anyway. `is_assigned` is especially useful because crates relying on the stability guarantees of the other Unicode methods in `char` may wish to reject unassigned characters where those guarantees do not hold. I'll add a tracking issue if this is approved. The `is_assigned` vs `is_unassigned` bikeshed probably needs libs-API review before merging? @rustbot label A-Unicode T-libs-api r? @Mark-Simulacrum

@rustbot

Rollup merge of #157946 - Jules-Bertholet:char-unassigned-private-use, r=Mark-Simulacrum Make `char::is_private_use` and `char::is_assigned` unstably public See also #157944, #154849. These functions are used in the implementation of `char::escape_debug()`, and there's no reason to force crates to duplicate data tables that std has to ship anyway. `is_assigned` is especially useful because crates relying on the stability guarantees of the other Unicode methods in `char` may wish to reject unassigned characters where those guarantees do not hold. I'll add a tracking issue if this is approved. The `is_assigned` vs `is_unassigned` bikeshed probably needs libs-API review before merging? @rustbot label A-Unicode T-libs-api r? @Mark-Simulacrum

@rustbot

…, r=Mark-Simulacrum Make `char::is_private_use` and `char::is_assigned` unstably public See also rust-lang/rust#157944, rust-lang/rust#154849. These functions are used in the implementation of `char::escape_debug()`, and there's no reason to force crates to duplicate data tables that std has to ship anyway. `is_assigned` is especially useful because crates relying on the stability guarantees of the other Unicode methods in `char` may wish to reject unassigned characters where those guarantees do not hold. I'll add a tracking issue if this is approved. The `is_assigned` vs `is_unassigned` bikeshed probably needs libs-API review before merging? @rustbot label A-Unicode T-libs-api r? @Mark-Simulacrum

@rustbot

…, r=Mark-Simulacrum Make `char::is_private_use` and `char::is_assigned` unstably public See also rust-lang/rust#157944, rust-lang/rust#154849. These functions are used in the implementation of `char::escape_debug()`, and there's no reason to force crates to duplicate data tables that std has to ship anyway. `is_assigned` is especially useful because crates relying on the stability guarantees of the other Unicode methods in `char` may wish to reject unassigned characters where those guarantees do not hold. I'll add a tracking issue if this is approved. The `is_assigned` vs `is_unassigned` bikeshed probably needs libs-API review before merging? @rustbot label A-Unicode T-libs-api r? @Mark-Simulacrum

Jules-Bertholet · 2026-07-30T00:58:52Z

@rustbot ready

Mark-Simulacrum

r=me with tracking issue added.

View changes since this review

rustbot · 2026-08-03T00:29:40Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-08-05T18:31:36Z

⚠️ Warning ⚠️

This PR is based on an upstream commit that is older than 28 days.

It's recommended to update your branch according to the rustc-dev-guide.

Jules-Bertholet · 2026-08-05T18:32:13Z

@rustbot ready

@rustbot

…, r=Mark-Simulacrum Make `char::is_private_use` and `char::is_assigned` unstably public See also rust-lang/rust#157944, rust-lang/rust#154849. These functions are used in the implementation of `char::escape_debug()`, and there's no reason to force crates to duplicate data tables that std has to ship anyway. `is_assigned` is especially useful because crates relying on the stability guarantees of the other Unicode methods in `char` may wish to reject unassigned characters where those guarantees do not hold. I'll add a tracking issue if this is approved. The `is_assigned` vs `is_unassigned` bikeshed probably needs libs-API review before merging? @rustbot label A-Unicode T-libs-api r? @Mark-Simulacrum

Mark-Simulacrum · 2026-08-08T15:08:10Z

@bors squash

* Make `char::is_default_ignorable` unstably public * Add tracking issue Co-authored-by: Jules Bertholet <jules@bertholet.email>

rust-bors · 2026-08-08T15:08:30Z

🔨 2 commits were squashed into 9846cb6.

Mark-Simulacrum · 2026-08-08T15:13:40Z

@bors r+ rollup

rust-bors · 2026-08-08T15:13:42Z

📌 Commit 9846cb6 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…uwer Rollup of 9 pull requests Successful merges: - #156935 (Introduce a `PinSafePointer` trait that generalizes `PinCoerceUnsized`) - #159834 (Apply str debugger visualizer to `*const str`, `*mut str` and `Box<str>`) - #160663 (Suggest add async for function sig with return expr in body) - #160732 (Optimize slice::contains for one-byte BytewiseEq types) - #157944 (Make `char::is_default_ignorable` unstably public) - #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules) - #160754 (Rename more diagnostic files to `diagnostics.rs`) - #160755 (Merge `rustc_lint/lints.rs` into `diagnostics.rs`) - #160757 (Merge `rustc_attr_parsing/session_diagnostics.rs` into `diagnostics.rs`)

@rustbot

Rollup merge of #157944 - Jules-Bertholet:is-default-ignorable, r=Mark-Simulacrum Make `char::is_default_ignorable` unstably public Similar to #154849; this function is used in the implementation of `char::escape_debug()`, and there's no reason to force crates to duplicate a data table that std has to ship anyway. I'll add a tracking issue if this is approved. (I'll do the other data tables from #155527 in separate PRs.) @rustbot label A-Unicode T-libs-api Tracking issue: #160583 r? @Mark-Simulacrum

rustbot assigned Mark-Simulacrum Jun 15, 2026

This comment has been minimized.

Sign in to view

Jules-Bertholet changed the title ~~Promote char::is_default_ignorable from perma-unstable to unstable~~ Make char::is_default_ignorable public and unstable Jun 15, 2026

Jules-Bertholet force-pushed the is-default-ignorable branch from 6f96752 to 193e0d9 Compare June 15, 2026 23:27

Jules-Bertholet changed the title ~~Make char::is_default_ignorable public and unstable~~ Make char::is_default_ignorable unstably public Jun 15, 2026

Jules-Bertholet mentioned this pull request Jun 15, 2026

Make char::is_private_use and char::is_assigned unstably public #157946

Merged

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 30, 2026

Mark-Simulacrum requested changes Aug 3, 2026

View reviewed changes

Comment thread library/core/src/char/methods.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2026

Jules-Bertholet mentioned this pull request Aug 5, 2026

Tracking Issue for is_default_ignorable method on char #160583

Open

4 tasks

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 5, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2026

This comment has been minimized.

Sign in to view

Make char::is_default_ignorable unstably public

9846cb6

* Make `char::is_default_ignorable` unstably public * Add tracking issue Co-authored-by: Jules Bertholet <jules@bertholet.email>

rust-bors Bot force-pushed the is-default-ignorable branch from 16f2d7a to 9846cb6 Compare August 8, 2026 15:08

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2026

JonathanBrouwer mentioned this pull request Aug 8, 2026

Rollup of 9 pull requests #160774

Merged

rust-bors Bot merged commit c31da22 into rust-lang:main Aug 9, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 9, 2026

Jules-Bertholet deleted the is-default-ignorable branch August 9, 2026 02:32

Navigation Menu

Uh oh!

Uh oh!

Make `char::is_default_ignorable` unstably public - #157944

Make `char::is_default_ignorable` unstably public#157944
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Jules-Bertholet:is-default-ignorable

Jules-Bertholet commented Jun 15, 2026 •

edited by rustbot

Loading

Uh oh!

This comment has been minimized.

Mark-Simulacrum commented Jun 18, 2026

Uh oh!

Jules-Bertholet commented Jul 30, 2026

Uh oh!

Mark-Simulacrum left a comment •

edited by rustbot

Loading

Uh oh!

Uh oh!

rustbot commented Aug 3, 2026

Uh oh!

rustbot commented Aug 5, 2026

Uh oh!

Jules-Bertholet commented Aug 5, 2026

Uh oh!

Mark-Simulacrum commented Aug 8, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 8, 2026

Uh oh!

Mark-Simulacrum commented Aug 8, 2026

Uh oh!

rust-bors Bot commented Aug 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Jules-Bertholet commented Jun 15, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Mark-Simulacrum commented Jun 18, 2026

Uh oh!

Jules-Bertholet commented Jul 30, 2026

Uh oh!

Mark-Simulacrum left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rustbot commented Aug 3, 2026

Uh oh!

rustbot commented Aug 5, 2026

Uh oh!

Jules-Bertholet commented Aug 5, 2026

Uh oh!

Mark-Simulacrum commented Aug 8, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 8, 2026

Uh oh!

Mark-Simulacrum commented Aug 8, 2026

Uh oh!

rust-bors Bot commented Aug 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Jules-Bertholet commented Jun 15, 2026 •

edited by rustbot

Loading

Mark-Simulacrum left a comment •

edited by rustbot

Loading