Revive L4Re target by farao · Pull Request #150885 · rust-lang/rust

farao · 2026-01-09T17:13:31Z

This revives the target for the L4Re OS. It changes the way, linking is done and adds aarch64 support and documentation including a maintainer for the target.

The update of the libc crate is necessary since only in 0.2.179 and higher is the fixed support for L4Re on uclibc.

rustbot · 2026-01-09T17:13:35Z

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

These commits modify compiler targets.
(See the Target Tier Policy.)

rustbot · 2026-01-09T17:13:37Z

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2026-01-10T17:21:31Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred in GUI tests.

cc @GuillaumeGomez

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @lolbinarycat

GuillaumeGomez · 2026-01-10T17:22:55Z

Wrong rebase.

farao · 2026-01-10T17:29:24Z

Sorry for rebasing on an old commit by mistake

rust-bors · 2026-01-14T16:53:30Z

☔ The latest upstream changes (presumably #151107) made this pull request unmergeable. Please resolve the merge conflicts.

joboet

I can only comment on the library changes, those seem mostly fine to me.

View changes since this review

joboet · 2026-01-22T13:35:48Z

Does L4Re truly not support networking? All the necessary functions seem to be available in libc. What happens if you remove the L4Re special case from sys/net/connection/mod.rs?

Regarding the libc functions: L4Re's uclibc adaptation has a variety of these function which will when called just return an error or a disabled status code. I decided to put these in the libc crate because that should imo just bluntly mirror the functions when they exist, no matter if they are somehow disabled.

joboet · 2026-01-22T13:44:29Z

    #[allow(deprecated)]
    fn as_raw_stat(&self) -> &raw::stat {
-        unsafe { &*(self.as_inner().as_inner() as *const libc::stat64 as *const raw::stat) }
+        panic!("as_raw_stat not supported for L4Re");


How that? stat does appear in libc.

You're right, I'll change it back.

farao · 2026-01-29T09:51:59Z

Thanks for having a look! I realised that I need to disable some std tests for the std test suite to run through, I will make a small update to this PR this or next week.

Regarding networking (and to a somewhat lesser extent for fs): We do have initial support but that's opt-in and likely about to change, therefore we decided that this should be/stay disabled for now.

joboet · 2026-02-07T15:22:55Z

I'm just a bit worried about this removing the stable AsFd/... implementations for the sockets...

joboet · 2026-02-07T15:34:41Z

@rustbot author

farao · 2026-08-06T13:06:28Z

All successful after the rebase! @JonathanBrouwer or @joboet can we enqueue it in bors again?

JonathanBrouwer · 2026-08-06T13:10:27Z

The failed gcc test was indeed caused by something else, not by this PR. I'm not really comfortable reviewing this code so I'll wait for @joboet or someone else to approve

joboet · 2026-08-06T13:10:47Z

@bors r=@saethlin,joboet

rust-bors · 2026-08-06T13:10:50Z

📌 Commit f2dd932 has been approved by saethlin,joboet

It is now in the queue for this repository.

joboet · 2026-08-06T13:13:36Z

crate::sys::unsupported was depending on the platform either a function or a module containing an unsupported function. I resolved this by removing the module unsupported around the unsupported* functions in library/std/src/sys/pal/unix/mod.rs. Is this fix ok for you?

Yes, very much. The added consistency with the other targets is definitely worth the slight #[cfg]-duplication.

Revive L4Re target This revives the target for the L4Re OS. It changes the way, linking is done and adds aarch64 support and documentation including a maintainer for the target. The update of the libc crate is necessary since only in 0.2.179 and higher is the fixed support for L4Re on uclibc.

Rollup of 14 pull requests Successful merges: - #150885 (Revive L4Re target) - #159643 (Add support for splatted function pointers) - #160433 (delegation: add support for wrapping of the return value with `From::from`) - #160530 (refactor handling of target features in Session) - #160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`) - #160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items) - #160634 (miri subtree update) - #158904 (Fix FutureDropPoll shim for by-move async closures) - #160335 (dlopen offload) - #160445 (codegen: classify localized MSVC linker progress as linker_info) - #160504 (cleanup borrowck, improve c-variadic handling) - #160587 (Add regression test for associated type outlives bound at call site) - #160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.) - #160636 (derive(Diagnostic): link to proper docs)

Revive L4Re target This revives the target for the L4Re OS. It changes the way, linking is done and adds aarch64 support and documentation including a maintainer for the target. The update of the libc crate is necessary since only in 0.2.179 and higher is the fixed support for L4Re on uclibc.

…uwer Rollup of 21 pull requests Successful merges: - #159784 (Hint that memchr returns an in-bounds index) - #150885 (Revive L4Re target) - #159643 (Add support for splatted function pointers) - #160433 (delegation: add support for wrapping of the return value with `From::from`) - #160530 (refactor handling of target features in Session) - #160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`) - #160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items) - #160634 (miri subtree update) - #157641 (Do not promote extern statics) - #158904 (Fix FutureDropPoll shim for by-move async closures) - #160103 (Add regression test for GAT bound mismatched type error) - #160335 (dlopen offload) - #160445 (codegen: classify localized MSVC linker progress as linker_info) - #160499 (rustc_resolve: move diagnostic attribute linting to attr parsing) - #160504 (cleanup borrowck, improve c-variadic handling) - #160577 (expand: Feature gate AST-based attribute macros on expressions and statements) - #160587 (Add regression test for associated type outlives bound at call site) - #160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.) - #160636 (derive(Diagnostic): link to proper docs) - #160644 (Clean up some manual debug impls) - #160649 (move naked function ui tests)

Revive L4Re target This revives the target for the L4Re OS. It changes the way, linking is done and adds aarch64 support and documentation including a maintainer for the target. The update of the libc crate is necessary since only in 0.2.179 and higher is the fixed support for L4Re on uclibc.

…uwer Rollup of 20 pull requests Successful merges: - #159784 (Hint that memchr returns an in-bounds index) - #150885 (Revive L4Re target) - #159643 (Add support for splatted function pointers) - #160433 (delegation: add support for wrapping of the return value with `From::from`) - #160530 (refactor handling of target features in Session) - #160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`) - #160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items) - #160634 (miri subtree update) - #157641 (Do not promote extern statics) - #158904 (Fix FutureDropPoll shim for by-move async closures) - #160103 (Add regression test for GAT bound mismatched type error) - #160335 (dlopen offload) - #160445 (codegen: classify localized MSVC linker progress as linker_info) - #160499 (rustc_resolve: move diagnostic attribute linting to attr parsing) - #160504 (cleanup borrowck, improve c-variadic handling) - #160577 (expand: Feature gate AST-based attribute macros on expressions and statements) - #160587 (Add regression test for associated type outlives bound at call site) - #160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.) - #160636 (derive(Diagnostic): link to proper docs) - #160644 (Clean up some manual debug impls)

Revive L4Re target This revives the target for the L4Re OS. It changes the way, linking is done and adds aarch64 support and documentation including a maintainer for the target. The update of the libc crate is necessary since only in 0.2.179 and higher is the fixed support for L4Re on uclibc.

…uwer Rollup of 28 pull requests Successful merges: - #159784 (Hint that memchr returns an in-bounds index) - #160673 (Improve `canonical_param_env_cache`) - #150885 (Revive L4Re target) - #159643 (Add support for splatted function pointers) - #160433 (delegation: add support for wrapping of the return value with `From::from`) - #160530 (refactor handling of target features in Session) - #160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`) - #160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items) - #160683 (Add regression test for unknown feaeture name reported with other errors) - #157641 (Do not promote extern statics) - #158904 (Fix FutureDropPoll shim for by-move async closures) - #159816 (added note/help about iterator invalidation when mutating a collection inside a for loop) - #160103 (Add regression test for GAT bound mismatched type error) - #160335 (dlopen offload) - #160445 (codegen: classify localized MSVC linker progress as linker_info) - #160499 (rustc_resolve: move diagnostic attribute linting to attr parsing) - #160504 (cleanup borrowck, improve c-variadic handling) - #160577 (expand: Feature gate AST-based attribute macros on expressions and statements) - #160587 (Add regression test for associated type outlives bound at call site) - #160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.) - #160633 (delegation: fix determining wrong `FnKind` when delegation is inside const arg) - #160636 (derive(Diagnostic): link to proper docs) - #160644 (Clean up some manual debug impls) - #160649 (move naked function ui tests) - #160672 (Improve `MaybeLiveLocals`) - #160693 (Add branch config for perf. unrolling in bors) - #160696 (rustc_codegen_llvm: handle sm_101* features being an alias) - #160706 (renovate: clarify that vulnerability PRs are opened automatically)

Rollup merge of #150885 - farao:main, r=saethlin,joboet Revive L4Re target This revives the target for the L4Re OS. It changes the way, linking is done and adds aarch64 support and documentation including a maintainer for the target. The update of the libc crate is necessary since only in 0.2.179 and higher is the fixed support for L4Re on uclibc.

…uwer Rollup of 28 pull requests Successful merges: - rust-lang/rust#159784 (Hint that memchr returns an in-bounds index) - rust-lang/rust#160673 (Improve `canonical_param_env_cache`) - rust-lang/rust#150885 (Revive L4Re target) - rust-lang/rust#159643 (Add support for splatted function pointers) - rust-lang/rust#160433 (delegation: add support for wrapping of the return value with `From::from`) - rust-lang/rust#160530 (refactor handling of target features in Session) - rust-lang/rust#160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`) - rust-lang/rust#160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items) - rust-lang/rust#160683 (Add regression test for unknown feaeture name reported with other errors) - rust-lang/rust#157641 (Do not promote extern statics) - rust-lang/rust#158904 (Fix FutureDropPoll shim for by-move async closures) - rust-lang/rust#159816 (added note/help about iterator invalidation when mutating a collection inside a for loop) - rust-lang/rust#160103 (Add regression test for GAT bound mismatched type error) - rust-lang/rust#160335 (dlopen offload) - rust-lang/rust#160445 (codegen: classify localized MSVC linker progress as linker_info) - rust-lang/rust#160499 (rustc_resolve: move diagnostic attribute linting to attr parsing) - rust-lang/rust#160504 (cleanup borrowck, improve c-variadic handling) - rust-lang/rust#160577 (expand: Feature gate AST-based attribute macros on expressions and statements) - rust-lang/rust#160587 (Add regression test for associated type outlives bound at call site) - rust-lang/rust#160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.) - rust-lang/rust#160633 (delegation: fix determining wrong `FnKind` when delegation is inside const arg) - rust-lang/rust#160636 (derive(Diagnostic): link to proper docs) - rust-lang/rust#160644 (Clean up some manual debug impls) - rust-lang/rust#160649 (move naked function ui tests) - rust-lang/rust#160672 (Improve `MaybeLiveLocals`) - rust-lang/rust#160693 (Add branch config for perf. unrolling in bors) - rust-lang/rust#160696 (rustc_codegen_llvm: handle sm_101* features being an alias) - rust-lang/rust#160706 (renovate: clarify that vulnerability PRs are opened automatically)

rustbot assigned joboet Jan 9, 2026

This comment has been minimized.

Sign in to view

farao force-pushed the main branch from 7e76bdd to e66e2d0 Compare January 10, 2026 17:21

This comment has been minimized.

Sign in to view

farao force-pushed the main branch from e66e2d0 to 9036110 Compare January 10, 2026 17:25

This comment has been minimized.

Sign in to view

farao force-pushed the main branch from 9036110 to cd3369f Compare January 14, 2026 11:44

joboet reviewed Jan 22, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 6, 2026

JonathanBrouwer mentioned this pull request Aug 6, 2026

Rollup of 11 pull requests #160647

Closed

JonathanBrouwer mentioned this pull request Aug 6, 2026

Rollup of 10 pull requests #160654

Closed

jhpratt mentioned this pull request Aug 7, 2026

Rollup of 14 pull requests #160661

Closed

jhpratt mentioned this pull request Aug 7, 2026

Rollup of 14 pull requests #160667

Closed

JonathanBrouwer mentioned this pull request Aug 7, 2026

Rollup of 21 pull requests #160678

Closed

JonathanBrouwer mentioned this pull request Aug 7, 2026

Rollup of 20 pull requests #160682

Closed

jhpratt mentioned this pull request Aug 7, 2026

Rollup of 30 pull requests #160721

Closed

JonathanBrouwer mentioned this pull request Aug 7, 2026

Rollup of 28 pull requests #160725

Merged

rust-bors Bot merged commit 4eeee3b into rust-lang:main Aug 8, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 8, 2026

Uh oh!

Uh oh!

Conversation

farao commented Jan 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 9, 2026

Uh oh!

rustbot commented Jan 9, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jan 10, 2026

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Jan 10, 2026

Uh oh!

This comment has been minimized.

farao commented Jan 10, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jan 14, 2026

Uh oh!

joboet left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joboet Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

farao Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joboet Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

farao Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

farao commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joboet commented Feb 7, 2026

Uh oh!

joboet commented Feb 7, 2026

Uh oh!

farao commented Aug 6, 2026

Uh oh!

JonathanBrouwer commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joboet commented Aug 6, 2026

Uh oh!

rust-bors Bot commented Aug 6, 2026

Uh oh!

joboet commented Aug 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

farao commented Jan 9, 2026 •

edited by rustbot

Loading

joboet left a comment •

edited by rustbot

Loading

farao Jan 29, 2026 •

edited

Loading

farao commented Jan 29, 2026 •

edited

Loading

JonathanBrouwer commented Aug 6, 2026 •

edited

Loading