On name resolution error in parameter list, suggest possible const typo and avoid unnecessary second error - #149753
On name resolution error in parameter list, suggest possible const typo and avoid unnecessary second error#149753estebank wants to merge 3 commits into
const typo and avoid unnecessary second error#149753Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2745644 to
1ec76fe
Compare
estebank
changed the title
const typoconst typo and avoid unnecessary second error
There was a problem hiding this comment.
I'm unfamiliar with how delayed errors and PathSource works, so I'm probably not the right reviewer for determining if this is the correct solution.
The test changes look correct though, so feel free to either reassign, or just r=me if you don't think this is controversial.
| if self.diag_metadata.currently_processing_generic_args | ||
| && matches!(source, PathSource::Type) | ||
| { | ||
| source = PathSource::TypeParam; | ||
| } | ||
|
|
There was a problem hiding this comment.
It's not clear to me why we're overriding this only here, and not at a "higher" level (such as in smart_resolve_report_errors)?
There was a problem hiding this comment.
moved to it, but only after the error was created (to avoid changing the main message everywhere)
madsmtm
added
S-waiting-on-author
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
4 participants
Fix #149660.