Skip to content

Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678) - #138744

Open
Mallets wants to merge 9 commits into
rust-lang:mainfrom
Mallets:set_ipv6_sock_hop_limit
Open

Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678)#138744
Mallets wants to merge 9 commits into
rust-lang:mainfrom
Mallets:set_ipv6_sock_hop_limit

Conversation

@Mallets

@Mallets Mallets commented Mar 20, 2025 •
edited by rustbot
Loading

Copy link
Copy Markdown

View all comments

#94678 was closed because of time constraints of the original author (@kckeiks).

This PR is a refresh of #94678 where the original proposed changes are ported to the current status of the standard library.

In addition, this PR:

Issue: #139166

@rustbot

rustbot commented Mar 20, 2025

Copy link
Copy Markdown
Collaborator

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 20, 2025
@Mallets Mallets mentioned this pull request Mar 20, 2025
Merged
@ibraheemdev

ibraheemdev commented Mar 28, 2025

Copy link
Copy Markdown
Member

r? libs-api because it's been a while since the original PR was approved.

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 28, 2025
@rustbot rustbot assigned dtolnay and unassigned ibraheemdev Mar 28, 2025
dtolnay
dtolnay requested changes Mar 30, 2025
View reviewed changes
Comment thread library/std/src/net/tcp.rs Outdated
Comment thread library/std/src/net/tcp.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2025
@Mallets Mallets mentioned this pull request Mar 31, 2025
Open
4 tasks
@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Mar 31, 2025
@rustbot

This comment has been minimized.

Sign in to view
@Mallets
Mallets force-pushed the set_ipv6_sock_hop_limit branch from 7f790e2 to 9c1ee90 Compare March 31, 2025 10:13
@rustbot rustbot removed the has-merge-commits PR has merge commits, merge with caution. label Mar 31, 2025
@bors

bors commented Apr 13, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #139724) made this pull request unmergeable. Please resolve the merge conflicts.

@dtolnay

dtolnay commented Apr 13, 2025

Copy link
Copy Markdown
Member

Sorry—I missed that this was ready for review again. Please use @rustbot ready, which replaces S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label with S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. .

@dtolnay
dtolnay force-pushed the set_ipv6_sock_hop_limit branch from 9c1ee90 to 25fb525 Compare April 13, 2025 16:23
@dtolnay

dtolnay commented Apr 13, 2025

Copy link
Copy Markdown
Member

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2025
@dtolnay

dtolnay commented Apr 13, 2025

Copy link
Copy Markdown
Member

Thank you!

@bors r+

@bors

bors commented Apr 13, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 25fb525 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 13, 2025
@ChrisDenton
Rollup merge of rust-lang#138744 - Mallets:set_ipv6_sock_hop_limit, r…
ac13f79 
…=dtolnay

Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678)

rust-lang#94678 was closed because of time constraints of the original author (`@kckeiks).`

This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library.

In addition, this PR:
- implements the change suggested in rust-lang#94678 (comment)
- defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed

Issue: rust-lang#139166
@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Sep 20, 2025
@Mallets
Mallets force-pushed the set_ipv6_sock_hop_limit branch from a9dbefc to 9698730 Compare September 20, 2025 09:24
@dtolnay dtolnay added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 23, 2025
@bors

bors commented Dec 24, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #150334) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC

Dylan-DPC commented Mar 24, 2026

Copy link
Copy Markdown
Member

@Mallets any updates on this? thanks

@Mallets
Mallets force-pushed the set_ipv6_sock_hop_limit branch from 9698730 to b3c63c8 Compare March 24, 2026 11:10
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mallets

Mallets commented Mar 24, 2026

Copy link
Copy Markdown
Author

@Dylan-DPC, thank you for the reminder! I had completely overlooked this PR.
I’ve now updated it, and the CI seems to pass.

@Mallets

Mallets commented Jun 29, 2026

Copy link
Copy Markdown
Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2026
@Mallets

Mallets commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

@dtolnay @Dylan-DPC any chances we can merge this or is there something in the way?

@rust-bors

This comment has been minimized.

Sign in to view
@Mallets
Mallets force-pushed the set_ipv6_sock_hop_limit branch from 7402270 to b0fa536 Compare August 6, 2026 14:37
@rustbot

rustbot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels

O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Mallets @rustbot @ibraheemdev @bors @dtolnay @ChrisDenton @jhpratt @Dylan-DPC @rust-log-analyzer