Don't assume traits used as type are trait objs in 2021 edition

[VulnBandit]

Fixes #127548

When you use a trait as a type, the compiler automatically assumes you meant to use a trait object, which is not always the case.
This PR fixes the bug where you don't need a trait object, so the error message was changed to:

error[E0782]: expected a type, found a trait

Also fixes some ICEs:
Fixes #120241
Fixes #120482
Fixes #125512

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[rustbot]

HIR ty lowering was modified

cc @fmease

[VulnBandit]

@rustbot author

[jieyouxu]

This PR fixes the vunlnerability where you don't need a trait object

FYI the word "vunlnerability" has a specific meaning (i.e. a weakness that makes something easy to be attacked/exploited) in the context of this repo (e.g. related to compiler or std), but this PR is just trying to improve diagnostics not trying to address an exploit.

[VulnBandit]

I see vulnerability as when something is not right and I fix it. Ok I will change the word

[jieyouxu]

We usually call those those "bugs" or "diagnostic issues", "vulnerability" usually indicates an exploitable weakness that has to do with security that wg-security-response would need to look at.

[VulnBandit]

@rustbot review

[lcnr]

r=me after CI

[bors]

☔ The latest upstream changes (presumably #131511) made this pull request unmergeable. Please resolve the merge conflicts.

[lcnr]

@bors r+ rollup

[bors]

📌 Commit 9a2772e has been approved by lcnr

It is now in the queue for this repository.