Skip to content

Implement Region for smir - #116024

Merged
bors merged 13 commits into
rust-lang:masterfrom
ouz-a:smir_region
Sep 29, 2023
Merged

Implement Region for smir#116024
bors merged 13 commits into
rust-lang:masterfrom
ouz-a:smir_region

Conversation

@ouz-a

@ouz-a ouz-a commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Adds Region and it's relevant types to smir and covers them with stable implementation

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2023
@rustbot

rustbot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

@oli-obk

oli-obk commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

Please rebase the PR

oli-obk
oli-obk reviewed Sep 27, 2023
View reviewed changes
Comment thread compiler/rustc_smir/src/stable_mir/fold.rs
oli-obk
oli-obk reviewed Sep 27, 2023
View reviewed changes
Comment thread compiler/rustc_smir/src/stable_mir/ty.rs Outdated
oli-obk
oli-obk reviewed Sep 27, 2023
View reviewed changes
Comment thread compiler/rustc_smir/src/stable_mir/ty.rs Outdated
@bors

bors commented Sep 27, 2023

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #116193) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk
oli-obk reviewed Sep 27, 2023
View reviewed changes
Comment thread compiler/rustc_smir/src/stable_mir/ty.rs Outdated
@rustbot

rustbot commented Sep 28, 2023

Copy link
Copy Markdown
Collaborator

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

oli-obk
oli-obk requested changes Sep 28, 2023
View reviewed changes
Comment thread compiler/rustc_smir/src/rustc_smir/mod.rs Outdated
Comment thread compiler/stable_mir/src/fold.rs Outdated
Comment thread compiler/stable_mir/src/fold.rs Outdated
Comment thread compiler/stable_mir/src/visitor.rs Outdated
@oli-obk

oli-obk commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 34f10e2 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2023
@oli-obk

oli-obk commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request Sep 29, 2023
Merged
@bors
bors merged commit 26be575 into rust-lang:master Sep 29, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 29, 2023
@pvdrz pvdrz mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk requested changes

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.74.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ouz-a @rustbot @oli-obk @bors