feat(mem_replace_with_default): also emit inside macros - #17191
Merged
Conversation
Contributor
Author
rustbot
added
the
S-blocked
|
No changes for b8c36b0 |
ada4a
force-pushed
the
mem_replace_with_default-in-macros
branch
6 times, most recently
from
June 9, 2026 10:15
6b17a21 to
75f3e2d
Compare
This was originally not done because emitting suggestions in macros used to not work well.[^1] That's fortunately no longer the case. This allows folding `mem_replace_with_default_macro` into the regular test files -- both the std and the no-std one. [^1]: rust-lang#4881 (comment)
ada4a
force-pushed
the
mem_replace_with_default-in-macros
branch
from
June 9, 2026 13:36
75f3e2d to
b8c36b0
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
ada4a
marked this pull request as ready for review
June 9, 2026 13:37
Collaborator
|
r? @dswij rustbot has assigned @dswij. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
cc @samueltardieu as you've looked at the previous PR |
dswij
approved these changes
Jun 9, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally not done because emitting suggestions in macros used to not work well.1 That's fortunately no longer the case.
This allows folding
mem_replace_with_default_macrointo the other test files -- both the regular and the no-std one.changelog: [
mem_replace_with_default]: also emit inside macrosFootnotes
https://github.com/rust-lang/rust-clippy/pull/4881#discussion_r361164219 ↩