fix: remove extra spaces in full function signatures - #23070
Open
lingyaochu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23069
When
rust-analyzer.completion.fullFunctionSignatures.enableis set totrue, completion descriptions are generated bydetail_full, which internally callswrite_function()to produce the signature. For functions with more than four parameters, the generated signature is multi-line:rust-analyzer/crates/hir/src/display.rs
Lines 195 to 210 in ece721d
Take the
compare_exchange()function as an example, the final generated signature for this function is like:Flattening this output in
detail_fullpreviously inserted a space right after(and right before), e.g.pub fn compare_exchange( &self, ... ).This PR makes a small change to
detail_fullto skip the whitespace insertion around the parentheses.