internal: update next-solver to 0.166 - #22939
Merged
Merged
Conversation
ChayimFriedman2
self-requested a review
July 28, 2026 16:09
ChayimFriedman2
approved these changes
Jul 28, 2026
Contributor
Author
That, but also because of the fact that, if I were to jump across multiple versions, I'd like to have a commit per version, but then I wouldn't be able to link the relevant PRs, because rustbot would complain... |
Contributor
|
You absolutely can put links in commit messages, you just need them to be full ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small PR to see if I'm doing things right.
This update seems to consist of just rust-lang/rust#156246, which changes
Interner::for_each_{blanket,relevant}_implto be able to early-return, using theVisitorResulttype. My adaptation mostly involved:.for_eachwith for-loops, to allow early-returning (.try_for_eachunfortunately doesn't work, asVisitorResultisn'tTry)ret!macro introduced in the upstream PR. Upstream only needs it in one place, while we need it in four, so I put it intonext_solver/util.rs.cc @ChayimFriedman2