fix: don't complete .await on receivers of unknown type - #22486
Merged
Conversation
rustbot
added
the
S-waiting-on-review
ada4a
marked this pull request as draft
May 29, 2026 16:25
rustbot
removed
the
S-waiting-on-review
ChayimFriedman2
previously requested changes
May 30, 2026
ada4a
force-pushed
the
22478-spurious-await
branch
from
June 1, 2026 19:26
21a8536 to
fd4b9ff
Compare
ada4a
marked this pull request as ready for review
June 1, 2026 19:26
rustbot
added
the
S-waiting-on-review
ada4a
force-pushed
the
22478-spurious-await
branch
2 times, most recently
from
June 1, 2026 19:40
dac2dfe to
0f3c0ec
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Veykril
approved these changes
Jun 6, 2026
ada4a
force-pushed
the
22478-spurious-await
branch
from
June 17, 2026 11:24
0f3c0ec to
52ecb67
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
ada4a
force-pushed
the
22478-spurious-await
branch
from
June 17, 2026 11:53
52ecb67 to
6037856
Compare
rustbot
removed
the
S-waiting-on-review
Contributor
Author
|
I was actually waiting for a response to #22486 (comment), but I can do that as a separate PR if needed |
Member
|
ah my bad. But yea we can address that if Chayim finds t he time look over that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22478
This also happens to improve syntax highlighting in presence of error types, and therefore fixes #22487