builder: unify target/doc finding, support json file in get_coverage - #3430
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
marked this pull request as ready for review
August 5, 2026 00:45
GuillaumeGomez
approved these changes
Aug 5, 2026
Member
|
Thanks! |
github-actions
Bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is coming from a bugfix in rustdoc which changes behaviour for the coverage output.
Before we always got the coverage output in stdout. Now, the
-oarg is used, which is set to./target/docbycargowhen it calls rustdoc.Without dropping to raw rustdoc, the only option is to switch our coverage-reading to reading the local file.
While I'm on it, I unified the logic to find the doc output directory, and the logic to find a single json file in the output dir.
The legacy stdout logic I left in for now, so we can deploy this change with the old frozen nightly version, and then unfreeze nightly as we wish. Later I can remove that part too.
this also fixes the currently failing CI on
main