Skip to content

build queue: refactor & cache priority-finding for new releases - #3378

Open
syphar wants to merge 1 commit into
rust-lang:mainfrom
syphar:cached-priorities
Open

build queue: refactor & cache priority-finding for new releases#3378
syphar wants to merge 1 commit into
rust-lang:mainfrom
syphar:cached-priorities

Conversation

@syphar

@syphar syphar commented Jun 20, 2026

Copy link
Copy Markdown
Member

prep-work for the SQS ingestion from crates.io so we support a higher load in event ingestion without all these queries.

Also, unifies the priority logic in one struct that is easily testable.

We still need a call (refresh_default_priorities) every now and then, which would update priorities of already queued releases, if the underlying data changes (patterns, workspace sizes, ...), but that's more optional.

While I was on it, I also added a builder to the FakeGithubStats struct and improved some code quality in tests

@syphar syphar self-assigned this Jun 20, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jun 20, 2026
@syphar
syphar force-pushed the cached-priorities branch 3 times, most recently from f519c43 to 54fbb41 Compare June 20, 2026 05:09
@syphar syphar changed the title WIP: cache crate priority overrides build queue: refactor & cache priority-finding for new releases Jun 20, 2026
@syphar
syphar marked this pull request as ready for review June 20, 2026 05:13
@syphar
syphar requested a review from a team as a code owner June 20, 2026 05:13
@syphar
syphar force-pushed the cached-priorities branch from 15607ca to 96f788a Compare June 20, 2026 06:25
@rustbot

This comment has been minimized.

@syphar
syphar marked this pull request as draft August 5, 2026 07:05
@syphar
syphar force-pushed the cached-priorities branch from 96f788a to d33a1e7 Compare August 5, 2026 07:42
@syphar
syphar marked this pull request as ready for review August 5, 2026 07:59
@syphar
syphar force-pushed the cached-priorities branch from d33a1e7 to b941287 Compare August 6, 2026 08:56
@rustbot

rustbot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants