Use serialize() instead of to_vec() for signatures - #1050
Merged
apoelstra merged 2 commits intoSep 18, 2026
Merged
Conversation
`to_vec()` allocated a `Vec` just to read its length. `serialize()` yields the same bytes on the stack, without a heap allocation.
The helper built signature bytes via `to_vec()` and by appending the sighash byte to DER by hand. Tests only need `&[u8]`, so store `SerializedSignature` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
to_vec()withserialize()on signatures where an ownedVec<u8>is not needed.The remaining
to_vec()calls on signatures are left as is: an ownedVec<u8>is required there by public API or by surrounding code.Closes #687