ci: consolidate rbmt version configuration and align local workflows - #1049
Open
ANAMASGARD wants to merge 2 commits into
Open
ANAMASGARD wants to merge 2 commits into
ANAMASGARD wants to merge 2 commits into
Conversation
Use Cargo metadata as the version source for installation and weekly updates, enabling rbmt's runtime version check. Generated with assistance from OpenAI Codex. Assisted-by: GPT-6 Astra Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
Use the pinned formatter and CI defaults for docs and benchmarks. Preserve the benchmark filter and conservative lockfile helper. Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
Member
|
Can we please copy/paste the approach used in rust-bitcoin/rust-bitcoin#6547? It's more compact (using grep rather than sed) but more importantly, I don't want a proliferation of different LLM-generated hacks to parse Cargo.toml. Let's stick with one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #945
Moved the cargo-rbmt version pin into Cargo.toml so rbmt can check that the installed version matches the repository’s configuration. Update CI installation and weekly automation to read this pin, then remove rbmt-version.
Route local formatting, docs and benchmarks through rbmt to use the same pinned toolchain and defaults as CI. Keep the existing lockfile helper because rbmt’s lock command changes dependency-resolution behavior.
Validated formatting, docs, benchmark compilation, workflow syntax and updater behavior.