Prevent ambiguous mnemonic panics and preserve language roundtrip through serde - #108
Open
tnull wants to merge 2 commits into
Open
Prevent ambiguous mnemonic panics and preserve language roundtrip through serde#108tnull wants to merge 2 commits into
tnull wants to merge 2 commits into
Conversation
Valid Chinese mnemonics can use words shared by the Simplified and Traditional lists. Entropy recovery redetects their language and unwraps the ambiguity error, causing a panic for otherwise valid values. Recover entropy directly from the stored, validated word indices. Co-Authored-By: HAL 9000
Serde currently stores only the displayed phrase. A phrase shared by the Simplified and Traditional Chinese lists cannot be auto-detected during deserialization, so a valid serialized mnemonic cannot be restored. Add a versioned language tag for ambiguous phrases while retaining the legacy string representation and reader behavior elsewhere. Co-Authored-By: HAL 9000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106.