Repository navigation
chore(release): prepare v0.18.2 changelog - #334
Conversation
runbear-bot
left a comment
There was a problem hiding this comment.
Bobb's bot(Totoro) Review
Conclusion: not-ready
CHANGELOG.md:25-27: “within an eight-second budget” overstates the implementation.serveUntilSignalledcreates an 8-second context, but room history/head operations and lease release usecontext.Background(), while the local CAS lock can block inflock; a storage stall can therefore outlive the claimed budget. Describe this as an 8-second shutdown context, or make the complete shutdown path deadline-aware.CHANGELOG.md:42-45: the newly reconstructedv0.18.1section omits major features shipped by thev0.18.1tag, including Data queries and app principals/keys/grants. Add concise entries for those shipped features, or avoid presenting this as the completev0.18.1release record.
Verification: git diff --check passed. No repository test suite applies to this changelog-only diff; Go was unavailable, so no Go tests were run (0 / 0 / 0).
runbear-bot
left a comment
There was a problem hiding this comment.
Bobb's bot(Totoro) Review
Conclusion: ready-with-notes
No blocking findings in the current CHANGELOG.md diff. The release entries and the narrowed v0.18.1 scope are consistent with the locally available implementation history and source.
Notes:
- The v0.18.1 section intentionally preserves two fixes and links to the original release for the complete commit list; the linked release page and external issue/PR references were not independently checked in this static review.
git diff --checkpassed. No repository test suite applies to this changelog-only diff (0 / 0 / 0). Runtime, cross-process, live-provider, and deployment verification were not run.
Reviewed head: 184388b9ab085a6f521f58607153a4aba3b9a061.
184388b to
8b07f79
Compare
runbear-bot
left a comment
There was a problem hiding this comment.
Bobb's bot(Totoro) Review
Conclusion: ready-with-notes
No blocking findings in the current CHANGELOG.md diff. The prior shutdown-budget wording concern is resolved: the entry now describes local file-lock cancellation and explicitly limits other backends and hard kills. The v0.18.1 completeness concern is also resolved: the section states that it preserves two entries and links the original release for the full record.
Notes:
- The linked v0.18.1 release page and cited issue/PR references were not independently checked in this static review.
git diff --checkpassed. No repository test suite applies to this changelog-only diff (0 / 0 / 0). Runtime, live-provider, and deployment checks were not run (not applicable to documentation-only changes).
Reviewed head: 8b07f79fdec38ba36082ef1151d6bfa4d785f5ef.
TL;DR
Scope
This PR changes only
CHANGELOG.md, based on the PR #333 merge, f9fd8830e7db4527d01f9a13f246a7a7abf0ce2a. The initial changelog cut is amended to clarify shutdown timing and historical scope. No application code, build configuration, or release metadata changes.The changelog keeps
Unreleasedempty and adds v0.18.2. Its v0.18.1 section preserves two previously listed fixes and links to the original release for the full commit list; it is not a complete historical reconstruction. The original two bullets and the v0.18.0 and older sections remain unchanged.Release content
Source basis
Baseline: v0.18.1 at 64b6af4609c70b3da886b6659ff10ed93c1a2475.
The original five-entry product/documentation source inventory is co-editing coordination, README links, MCP metadata, watcher scans, and Redis error hygiene. This changelog-only release commit is separate from that inventory.
PR #333's merge preserves the validated
2d797f0tree; this release commit adds only the changelog cut. The watcher resource fix and share-link accounting fix were already included in v0.18.1 and are not new v0.18.2 features.Verification
At source commit
2d797f0f4a62ba6ab09525bfcffe1bd5a8728bbc, the Go suite (12 packages), vet, build, focused collaboration tests, selected webapp race tests, and baseline-suite overlay passed. Installed snapshot smoke checks passed twice, covering device setup, two-device sync, viewer/upload behavior, and shutdown. The installed malformed Redis cases rejected configuration without echoing the tested values.The pre-release snapshot produced four archive targets; only macOS arm64 was executed. Windows-specific execution, live external GCS/S3 and managed Redis checks were not performed. Existing browser test failures remain, so these results do not establish a fully green browser suite or verification of the final public package.
Release status
Release publication is on hold. Independent testing reproduced a separate shutdown deadline violation under local storage lock contention. This changelog-only PR clarifies the existing shutdown behavior; it does not fix that runtime issue. No v0.18.2 tag or release has been published.