Repository navigation
Fix geocoding - #1210
Merged
Merged
Fix geocoding#1210
Conversation
We noticed on RUG::B that our latest locations weren't geocoded/ ended up in the middle of the ocean which was a bit odd. After looking into it, turns out that's due to the geocoding service used here requiring an HTTP header to identify yourself. So, that was added along with a couple of fail safes against the `nil`/`nil` -> 0/0 rendering. Based on the dev setup branch/#1209 since I needed those changes here.
Merged
salzig
reviewed
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed on RUG::B that our latest locations weren't geocoded/ ended up in the middle of the ocean which was a bit odd.
After looking into it, turns out that's due to the geocoding service used here requiring an HTTP header to identify yourself.
So, that was added along with a couple of fail safes against the
nil/nil-> 0/0 rendering.Based on the dev setup branch/#1209 since I needed those changes here. So PR made against that branch for now, to just see those changes.