fix(http): require Origin header on WebSocket upgrades (SEC-88)#208
fix(http): require Origin header on WebSocket upgrades (SEC-88)#208aris1009 wants to merge 1 commit into
Conversation
|
No breaking data contract changes detected in this PR. The changes are limited to WebSocket Origin-header enforcement ( |
🔒 Scanned for secrets using gitleaks 8.30.1
34dc89b to
c71e5e0
Compare
|
No breaking data contract changes detected in this PR. This change is a server-side security fix ( |
Docker Preview Images ReadyPreview Docker images have been built for this PR: ECR (internal): docker pull 422074288268.dkr.ecr.us-east-1.amazonaws.com/rudderstack/profiles-code-server:pr-208Image Details:
Test the image: docker run --rm -p 8080:8080 422074288268.dkr.ecr.us-east-1.amazonaws.com/rudderstack/profiles-code-server:pr-208
|
Summary
Originheader. Browsers always send it on WS upgrades (RFC 6455 §10.2); a missing value is either a non-browser client or a forged upgrade.ensureOriginis only mounted onwsRouter.wshandlers, so HTTP API clients are unaffected.Test plan
authenticateOrigintable updated; new case asserts missing Origin throws even when the host header is valid.jest test/unit/node/http.test.ts— 53 passed, 0 failed.Closes SEC-88.