Skip to content

fix(sec-90): remove '*' wildcard bypass from authenticateOrigin#203

Open
aris1009 wants to merge 1 commit into
mainfrom
fix/sec-90-drop-wildcard-origin
Open

fix(sec-90): remove '*' wildcard bypass from authenticateOrigin#203
aris1009 wants to merge 1 commit into
mainfrom
fix/sec-90-drop-wildcard-origin

Conversation

@aris1009
Copy link
Copy Markdown
Member

@aris1009 aris1009 commented May 5, 2026

Summary

  • Drop the `"*"` short-circuit in `authenticateOrigin()` so the origin allowlist cannot be globally disabled.
  • Behavior change: a literal `*` in `--trusted-origins` no longer bypasses the host-vs-origin check; only exact matches are honored.
  • Fork divergence from upstream; required for the SEC-84/SEC-90 hardening track.

Test plan

  • `./test/node_modules/.bin/jest --testPathPattern "node/http.test"` (49 passed)
  • Verify no internal deployment relies on `--trusted-origins=*` (none expected — the flag has never been wired in our deployments; see sibling PR rudderlabs/rudder-sources#3349)

🔒 Scanned for secrets using gitleaks 8.30.1
@aris1009 aris1009 requested a review from debanjan97 May 5, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant