Skip to content

Close stdin before terminating a timed-out memory leak child #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k0kubun merged 2 commits into from
Oct 27, 2026
Merged

Close stdin before terminating a timed-out memory leak child #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1313e3f
Close stdin before terminating a timed-out memory leak child
wtn Oct 26, 2026
f2f7691
Revert a failing test change
k0kubun Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/core_assertions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,12 +324,12 @@ def assert_no_memory_leak(args, prepare, code, message=nil, limit: 2.0, rss: fal
end
rescue Timeout::Error
timed_out = Time.now
in_p.close
status = begin
EnvUtil.terminate(pid, opt.fetch(:signal, :TERM), opt[:pgroup], opt.fetch(:reprieve, 1))
rescue Errno::ESRCH, Errno::ECHILD
warn "child not found: #{pid}: #$!"
end
in_p.close
end
stdout = out_reader.value
if timed_out
Expand Down
Loading