Repository navigation
Coerce byte lengths before validating returned size - #79
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coerce byte lengths once before passing them to the selected backend, matching the integer conversion accepted by Random.bytes and avoiding false partial-read errors.
Reproduction and verification
The baseline raises NotImplementedError even though the native backend returned the requested coerced number of bytes. Integers retain a fast path; random_bytes/hex and other formatter methods still call gen_random directly.
rbenv exec rake test: 3 tests / 68 assertions, zero failures/errors on the baseline, this isolated branch and the cumulative release-based consumer, Ruby 4.0.6/macOS. The existing disabled PID-recycling stress test was not enabled.rdoc -Cchecks pass (100% of its documentation inventory).Breaking changes and limitations
Previously rejected fractional/to_int lengths now work; non-convertible inputs remain TypeError, with a clearer size diagnostic. Invalid Float conversion now agrees with Random.bytes. No RNG backend, random-byte content, or entropy algorithm changes.
No production execution, statistical randomness claim, or cross-platform CI claim. Older Ruby/native fallback environments need upstream CI. The shared Random::Formatter implementation belongs to Ruby itself and is not changed here.