Skip to content

Optimization of REXML::Parent#index #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naitoh wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −3
Open

Optimization of REXML::Parent#index #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions benchmark/xpath.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ prelude: |
xml = '<a>' * DEPTH + '</a>' * DEPTH
doc = REXML::Document.new(xml)

WIDTH = 200
xml_wide = '<root>' + '<child/>' * WIDTH + '</root>'
doc_wide = REXML::Document.new(xml_wide)
first_child = doc_wide.root.children.first
last_child = doc_wide.root.children.last

benchmark:
"REXML::XPath.match(REXML::Document.new(xml), 'a//a')" : REXML::XPath.match(doc, "a//a")
"REXML::XPath.match(REXML::Document.new(xml), '//a//a')" : REXML::XPath.match(doc, "//a//a")
"REXML::Document.new(xml_wide).root.children.first.next_sibling_node" : first_child.next_sibling_node
"REXML::Document.new(xml_wide).root.children.last.previous_sibling_node" : last_child.previous_sibling_node
4 changes: 1 addition & 3 deletions lib/rexml/parent.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@ def to_a
# @return the index of the child, or nil if the object is not a child
# of this parent.
def index( child )
count = -1
@children.find { |i| count += 1 ; i.hash == child.hash }
count
@children.index { |c| c.equal?(child) }
end

# @return the number of children of this parent
Expand Down
Loading