Support previews for stacked pull requests - #1807
Draft
st0012 wants to merge 1 commit into
Draft
Conversation
Documentation previewCommit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked pull requests target another branch in
ruby/rdoc. The trusted preview resolver currently rejects these builds because it only acceptsmaster.This change keeps the base repository fixed to
ruby/rdocand accepts any branch in that repository. The workflow records the exact base branch. It checks the branch again before deployment and before the preview comment changes. If the head or base changes after the workflow binds the artifact, the run stops before deployment or skips the preview comment. Cloudflare secrets remain limited to the deployment step.Pull request edits now start the untrusted build workflow. As a result, a base retarget gets a new preview without maintainer approval.
A parent branch update does not change the child head. The preview updates after the child is restacked and the
synchronizeevent runs.