Repository navigation
Fix Interoperability with Zlib::GzipReader - #1082
Merged
Merged
Conversation
GzipReader offers both a read and to_io method. The read method returns the uncompressed file as a string. The to_io method returns the compressed file. The JSON.load method first tests for the to_io method and uses it before testing for the read method. This results in reading the compressed file, which is invalid JSON. Instead, we now test for the read method first.
Author
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GzipReader offers both a
readandto_iomethod. Thereadmethod returns the uncompressed file as a string. Theto_iomethod returns the compressed file. TheJSON.loadmethod first tests for theto_iomethod and uses it before testing for thereadmethod. This results in reading the compressed file, which is invalid JSON.Instead, we now test for the read method first.
I added a test that fails on the current
masterbranch to demonstrate the problem.