Skip to content

Use ruby/actions workflow for ruby versions #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-nakamura145 wants to merge 3 commits into
base: master
Choose a base branch
from
+17 −9
Open

Use ruby/actions workflow for ruby versions #136

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5119970
Use ruby/actions workflow for ruby versions
m-nakamura145 Jan 10, 2024
888d684
Update .github/workflows/ci.yml
m-nakamura145 Jan 10, 2024
6e2f4b9
Use string
m-nakamura145 Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,15 @@ on:
- pull_request

jobs:
ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby
min_version: 2.5
versions: "[debug]"
Copy link
Copy Markdown
Contributor

@olleolleolle olleolleolle Jan 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps like this:

Suggested change
versions: "[debug]"
versions:
- debug

...or perhaps it's called head, not debug?

Copy link
Copy Markdown
Contributor Author

@m-nakamura145 m-nakamura145 Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Copy Markdown
Member

@kou kou Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we can't use JSON array here...: https://github.com/ruby/fiddle/actions/runs/7472168103/workflow

The workflow is not valid. .github/workflows/ci.yml (Line: 14, Col: 9): A sequence was not expected

Copy link
Copy Markdown
Contributor Author

@m-nakamura145 m-nakamura145 Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. fixed 6e2f4b9


host:
needs: ruby-versions
name: >-
${{ matrix.os }} ${{ matrix.ruby }}
runs-on: ${{ matrix.os }}
Expand All @@ -17,14 +25,7 @@ jobs:
- macos-12
- ubuntu-latest
- windows-latest
ruby:
- '2.5'
- '2.6'
- '2.7'
- '3.0'
- '3.1'
- '3.2'
- debug
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
include:
- { os: windows-latest , ruby: mingw }
- { os: windows-latest , ruby: mswin }
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/libffi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,19 @@ name: libffi
on: [push, pull_request]

jobs:
ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby
min_version: 2.5

build:
needs: ruby-versions
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
ruby: [ head, 3.1, "3.0", 2.7, 2.6, 2.5 ]
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
libffi: [3.2.1]
libffi-prefix: [/tmp/local, '']

Expand Down