Add --dependencies and --offline options - #684
Open
lydell wants to merge 7 commits into
Open
Conversation
lydell
commented
Aug 9, 2026
| } | ||
|
|
||
| class OnlineAvailableVersionLister { | ||
| class AvailableVersionLister { |
Collaborator
Author
There was a problem hiding this comment.
It turned out that the OnlineAvailableVersionLister wasn’t doing anything online, and the OfflineAvaileableVersionLister was doing the same work, but wrongly only looked in one place (~/.elm/0.19.2/packages/, but not ~/.elm/pubgrub/). So I removed the “offline” one and renamed the “online” one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
--dependenciesand--offlineoptions, just likeelm-test-rs.--dependencies oldestis useful for package development. This is implemented by reversing the list of available versions for a package.I added
--offlinein the same PR, becauseelm-test-rsdocuments that--offlinedoes not work with--dependenciesand that made me think more about online and offline and what “newest” and “oldest” actually mean. To have--dependencies oldestand--dependencies newestwork correctly and in non-surprising ways, I needed to rethink some caching and online/offline behaviors around dependency solving.I also noted that the error message when a solve failed looked a bit out of context, and that we showed no progress output while solving online (slow). Before:
After: