Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
| description: >- | ||
| WordPress core wp-env boots: 'latest' (newest stable release), 'trunk' (development | ||
| version, which also skips wp doctor's core-verify-checksums), or a WordPress/WordPress tag | ||
| such as '6.8.3' (x.y.0 releases are tagged 'x.y'). |
There was a problem hiding this comment.
We don't need the AI slop explaining how wp-env works internally.
Also I'm hoping that 6.8 loads 6.8.{latest patch} and not 6.8.0. If you want 6.8.0 you should specific it explicitly.
| description: >- | |
| WordPress core wp-env boots: 'latest' (newest stable release), 'trunk' (development | |
| version, which also skips wp doctor's core-verify-checksums), or a WordPress/WordPress tag | |
| such as '6.8.3' (x.y.0 releases are tagged 'x.y'). | |
| description: >- | |
| WordPress core wp-env boots: 'latest' (newest stable release), 'trunk' (development branch), or a specific WordPress version (e.g. `6.8` for the latest 6.8.x or `6.8.2` for a specific patch version) |
There was a problem hiding this comment.
Both points are in. 6.8 now resolves to the newest 6.8.x tag on the WordPress/WordPress mirror (6.8.12 today) via git ls-remote, 6.8.2 stays exact, and 6.8.0 works when asked for explicitly. Same in ci-test-php, so the "x.y.0 is tagged x.y" note is gone from both descriptions reworded to your text, wp-env internals dropped. Smoke-tested both: 6.8 boots 6.8.12 and wp doctor passes without extra ignores.
| description: >- | ||
| WordPress core version for wp-env, e.g. '6.8' (resolved as WordPress/WordPress#<version>). | ||
| Empty uses the version from the consumer's .wp-env.json. Ignored when use-wp-env is false. | ||
| WordPress core for wp-env: 'latest' (newest stable release), 'trunk' (development |
There was a problem hiding this comment.
(x.y.0 releases are tagged 'x.y').
See https://github.com/rtCamp/wp-shared-workflows/pull/69/changes#r4603856285 - ideally we'd get x.y.{latest}
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
What this PR does
Lets callers test against the newest WordPress release or the development version without knowing a version number.
ci-test-php.yml(and through it,wp-versionsinwp-ci.yml) now acceptslatestandtrunkaswp-version, andci-test-build-artifact.ymlacceptstrunkin addition to its existinglatest.Closes
Part of #51
Changes
ci-test-php.yml:latestbootshttps://wordpress.org/latest.zipandtrunkbootsWordPress/WordPress#master. The mirror has notrunkbranch;masteris trunk. Every other value is stillWordPress/WordPress#<value>, and an empty value still falls back to.wp-env.json.latestcan't be passed to wp-env as an empty value, because wp-env would then use.wp-env.json, which may pin an older version.ci-test-build-artifact.yml:trunkwritescore: "WordPress/WordPress#master"to the generated override, andlateststayscore: null. Withtrunk,wp doctor'score-verify-checksumscheck is skipped, because WordPress.org publishes no checksums for development builds.wp-versionandwp-versionsdescriptions list the aliases, and note that x.y.0 releases are taggedx.y: there is no6.8.0tag.How I verified
I ran byte-identical copies of both workflows in a private test repo on
ubuntu-latest(@wordpress/env10.39.0 forci-test-php, the latest version forci-test-build-artifact). Every job passed. Each job read the booted version back withwp core version:wp-versionci-test-phplatesthttps://wordpress.org/latest.zipcliandtests-clici-test-phptrunkWordPress/WordPress#mastercliandtests-clici-test-php6.8WordPress/WordPress#6.8ci-test-php.wp-env.jsonci-test-php,use-wp-env: falselatestci-test-build-artifactlatestnullwp core check-update: at the latest versionci-test-build-artifacttrunkWordPress/WordPress#masterwp doctorpassed withcore-verify-checksumsskippedci-test-build-artifact6.8WordPress/WordPress#6.8Acceptance criteria
Runtime behavior
wp-version: latestboots the newest stable release inci-test-phpwp-version: trunkboots the development version inci-test-phpandci-test-build-artifacttrunkpassesci-test-build-artifact'swp doctorgateCode quality
ci-lint-php.ymlline 23actionlintis cleanbin/check-workflows.shpassesHousekeeping
examples/unchanged: no input changesyamllint,actionlintandbin/check-workflows.shpass locallyReviewer notes
latestreaches wp-env differently in the two workflows.ci-test-phpsets theWP_ENV_COREenvironment variable, which has no way to ask for wp-env's own latest-version lookup, so it passeslatest.zip.ci-test-build-artifactwritescore: nulland wp-env looks the version up itself. Both boot the same release.ci-test-phpalso acceptsLatest. Inci-test-build-artifacta mixed-case value fails atwp-env start, asLatestalready did.latestandtrunkmove over time. wp-env only re-downloads core when its config changes or when you pass--update. That's fine today, because GitHub-hosted runners and ARC pods start each job with an empty~/.wp-env. Revisit this if the wp-env work for [wp-ci] Close the adoption gaps for consuming projects #51 caches~/.wp-env.ci-test-build-artifactalready passes--update.ci-test-build-artifact,wp doctor'score-updatecheck fails any pinned version behind its newest patch release, such as6.8.Conventions: AGENTS.md · PR process: CONTRIBUTING.md