Skip to content

docs: follow up on the review notes from #842 and #844 - #845

Merged
aryanjasala merged 2 commits into
mainfrom
docs/review-followups
Nov 10, 2026
Merged

aryanjasala merged 2 commits into
mainfrom
docs/review-followups

Conversation

@aryanjasala

Copy link
Copy Markdown
Member

What this PR does

Picks up Aditya's notes on #842 and #844, which merged without them so the 2.0.1 release could go out tonight. Docs and comments only, no behaviour change.

Changes

  • webpack.blocks.config.js and docs/hmr.md said the wrapper exists because webpack-dev-server v5, pinned through overrides, rejects the object-form proxy wp-scripts emitted. Since fix(deps): update @wordpress/scripts to 37 and refresh stale npm overrides #842 that pin is gone and wp-scripts 37 runs webpack-dev-server 6 with an array-form proxy. The wrapper still removes it, for a different reason: the /build proxy target is hardcoded to localhost:8887, so with a custom BLOCKS_DEV_SERVER_PORT it points at another server. The comments and docs now say that.
  • docs/hmr.md also said allowedHosts: 'all' is set. The wrapper limits it to localhost and WP_HOST; the line now matches the code and the plugin's docs.
  • README.md, .claude/skills/README.md, docs/initialization.md and docs/internal/maintenance.md no longer say the task and epic issue templates stay after init, since chore: drop the duplicate security link and the Epic and Task templates #844 removed them.

How I verified

  • Checked @wordpress/scripts 37.0.0's config/webpack.config.js: the dev server's proxy is [ { context: [ '/build' ], target: 'http://localhost:8887', ... } ].
  • package-lock.json on main resolves webpack-dev-server 6.1.0, with no override.
  • node --check webpack.blocks.config.js; only comments changed in it.
  • git grep finds no other mention of the removed templates or of webpack-dev-server v5.

@aryanjasala
aryanjasala merged commit 85aeaab into main Nov 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants