Skip to content

fix(deps): require patched Node for CVE-2026-111497 - #820

Merged
aryanjasala merged 4 commits into
mainfrom
fix/node-cve-2026-111497
Nov 5, 2026
Merged

aryanjasala merged 4 commits into
mainfrom
fix/node-cve-2026-111497

Conversation

@Adi-ty

@Adi-ty Adi-ty commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Description

Raises .nvmrc to 22.23.4 and the engines floor to ^22.23.4 || ^24.22.1 || >=26.12.1, so installing on a Node release affected by CVE-2026-111497 (high, Brotli decoder OOB write) shows an npm EBADENGINE warning. The getting-started docs now name each patched line.

engines stays advisory on purpose. Node only runs dev tooling here (build, lint, tests, wp-env), never in production, so the exposure is minimal. An engine-strict commit was added and then reverted: it made installs fail on affected Node, which also broke CI. The shared wp-ci.yml@v1 doesn't read .nvmrc yet and installs the runner's cached Node 22.23.3. rtCamp/wp-shared-workflows#47 fixes that, and once it's merged and v1 is moved, CI here runs on 22.23.4.

Ref: https://nodejs.org/en/blog/vulnerability/october-2026-security-releases

Fixes/Covers issue

N/A

Node.js 22.23.4, 24.22.1 and 26.12.1 fix CVE-2026-111497, a high-severity out-of-bounds write in the Brotli decoder. Raise .nvmrc (which the shared CI workflows read) and the engines floor so earlier, affected releases warn on  install.
Ref: https://nodejs.org/en/blog/vulnerability/october-2026-security-releases
@Adi-ty
Adi-ty marked this pull request as ready for review October 23, 2026 12:43
Copilot AI balanced review requested due to automatic review settings October 23, 2026 12:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

npm engine requirements remain advisory, so normal installations can still proceed on runtimes below the patched-version floors.

1 open issue
What changed in this PR

Updates the theme’s Node.js requirements to target patched releases for CVE-2026-111497.

Changes:

  • Raises the .nvmrc version to 22.23.4.
  • Updates the supported Node.js ranges in the package manifest and lockfile.
  • Aligns the getting-started documentation with the new Node 22 minimum.
File Description
package.json Raises the declared Node.js engine requirements.
package-lock.json Synchronizes the root package’s engine requirements.
docs/​getting-started.md Updates the documented Node.js minimum.
.nvmrc Pins Node.js to 22.23.4.

Review effort: Balanced

Comment thread package.json Resolved
npm treats engines as advisory, so an affected Node only got an EBADENGINE warning. engine-strict makes npm ci / npm i (including Composer's npm i hook) fail instead. Patched 22.23.4 and 24.22.1 still install cleanly.
Copilot AI balanced review requested due to automatic review settings October 23, 2026 13:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Shared CI does not consume the updated Node pin and can select an older cached release that fails strict engine checks.

2 open issues

Review effort: Balanced

Comment thread .nvmrc Resolved
Adi-ty and others added 2 commits October 23, 2026 19:45
engine-strict turned the engines floor into a hard install failure. Node
here only runs dev tooling (build, lint, tests, wp-env), so CVE-2026-111497
exposure is minimal, and the security ask is the .nvmrc and engines bump,
not enforcement. engine-strict also failed CI, since the shared wp-ci@v1
installs the runner-cached Node 22.23.3 instead of reading .nvmrc
(rtCamp/wp-shared-workflows#47). Affected releases still get an npm
EBADENGINE warning.

This reverts commit 3abb8f4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"22.23.4 or later" read as if any newer Node were fine, but 24.21.0 is
newer and still affected, and engines rejects it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 23, 2026 14:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The four edits are consistent, but the security advisory’s patched-version thresholds remain independently unverified.

2 open issues

Review effort: Balanced

@Adi-ty
Adi-ty requested a review from aryanjasala October 23, 2026 14:22
@aryanjasala
aryanjasala merged commit 58aaf12 into main Nov 5, 2026
28 checks passed
@aryanjasala
aryanjasala deleted the fix/node-cve-2026-111497 branch November 5, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants