Repository navigation
fix(settings): show the server's message when a request fails - #388
Open
justlevine wants to merge 1 commit into
Open
justlevine wants to merge 1 commit into
justlevine wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
============================================
- Coverage 90.82% 85.87% -4.96%
============================================
Files 51 14 -37
Lines 3336 630 -2706
Branches 181 189 +8
============================================
- Hits 3030 541 -2489
+ Misses 255 34 -221
- Partials 51 55 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
justlevine
force-pushed
the
chore/settings-errors
branch
from
November 17, 2026 20:57
18813c3 to
49ac4ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a request on the settings or search screens fails, the admin now sees the error message the server (or apiFetch) sent back. The old fixed copy is still used when the error has no message.
Why
Related Issue(s):
How
( error as { message?: string } )?.message ||with the old copy as the fallback, the same inline patternpage.tsx,AlgoliaSettings.tsxandSiteIndexableEntities.tsxalready use.SiteTypeSettingsjust awaits the save and reloads, without the response check.{ code, message, data: { status } }and assert that message, and a few keep a{}rejection to cover the fallback copy.AI Disclosure
Opus 5.5 identified the mismatch and backported the initial version and draft PR description.
Testing Instructions
Screenshots
Additional Info
Checklist